From: Jeff Mahoney <jeffm@suse.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Jonghwa Lee <jonghwa3.lee@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Herbert Xu <herbert@gondor.hengli.com.au>,
Linux Kernel Maling List <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Mike Turquette <mturquette@ti.com>
Subject: Re: [PATCH] exynos-rng: Depend on ARCH_EXYNOS
Date: Mon, 27 Aug 2012 17:25:59 -0400 [thread overview]
Message-ID: <503BE5E7.106@suse.com> (raw)
In-Reply-To: <503BE429.7080301@codeaurora.org>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 8/27/12 5:18 PM, Stephen Boyd wrote:
> On 8/27/2012 2:02 PM, Jeff Mahoney wrote:
>> The exynos-rng device is only found on Samsung EXYNOS devices but
>> has dependencies that allow it to be built on other
>> architectures. This can result in build failures on powerpc due
>> to a missing clk_devm_get.
>>
>> This patch makes it depend on ARCH_EXYNOS.
>
> Hmm the point of making it not depend on ARCH_EXYNOS was so that
> it would get more build coverage. Is it devm_clk_get() that's
> missing? I believe Mark Brown sent some patches that move
> devm_clk_get() to common code so that we don't have these
> failures[1]. Can you try that patch?
>
> [1] https://lkml.org/lkml/2012/6/5/186
>
I'll give it a go since it should fix more than one issue for me. My
question remains, though: If this hardware is never going to be found
on powerpc hardware, what difference does it make if there is build
coverage there?
- -Jeff
- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.18 (Darwin)
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQIcBAEBAgAGBQJQO+XmAAoJEB57S2MheeWy4FgQALl7Ea62K19+3aObLCC+HLL4
5YSRG865SGPvLqMYxYuAf+aS+uVKeBk8YbnG51o6TXMrXbePv3bNtSR36J7JI1gd
9ogl5a9I/TtZUU+4+elDjy27Aew60Ask1Yv3SWYPm1NEqbUwuccb6vr2cm3tVyA4
en9WP67EUv0qwiCJvtFdYuNaPzMyFbLcwxvzQgAMk0+7H4cJ1FvZvKzVFP7SrGaa
G9HtY8f3Bxglk/hovQax8l5je8oa7IrU19jFu78t73+u44yfVEc8H5vzWKEARlI4
jsXH0l4X+NYZ1waBjoyQMPsNjbuwrwP0OW11gdN5WYk0kRvI8mX/mGiUNV+NyDl9
xr5ekUQidyYvOE+/HpV2hFu3NLux8xKOHJE8QtEOFiAuTAVVNZYHftZcTblPq6CC
/F7DJ9iMsxjcGOEvJplF1DG9gu6RsqYYV191PFLvXQgnl2cvcso7F/05ypBfaCTb
MJ+YVcdjvkrtNGDwBwE8wdOVwEWObDeLljiU0tLH4X6LziBbG68pthJBFpBesO5m
KT+doKUD6J/TIF0Jp2/zn/KhdUJf3wX2Ozb7stwWKa08/XFw4ghAJnl8D+4PUyKs
Izh6+L6LudearE2ZuOkNXlhB3PMeuQVK+b0BMbbZkHdPCErWE72sT06B3T9IbqgE
jXhuHdN7JWrgAAGPAiTn
=SA08
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2012-08-27 21:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-27 21:02 Jeff Mahoney
2012-08-27 21:18 ` Stephen Boyd
2012-08-27 21:24 ` Mark Brown
2012-08-27 21:25 ` Jeff Mahoney [this message]
2012-08-27 21:37 ` Mark Brown
2012-08-27 21:58 ` Jeff Mahoney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503BE5E7.106@suse.com \
--to=jeffm@suse.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=herbert@gondor.hengli.com.au \
--cc=jonghwa3.lee@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@ti.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome