From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C71C37F8A9 for ; Mon, 27 Apr 2026 07:43:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777275790; cv=none; b=pGxGMDMzvjNvCVVpIgPCnQaIXID2Bu4lnpRtJZ+vjY8UPEE+fR/wZ/FwUQmz3AJYSTJ7Dbg+O17GO+oUD5sD4CuD9mVp8jzV0OTFYyQyl6ucbwDFDNrAiphlxH20z4+B2hoRe6gm+VY6oO6xfTeOU6ilovYcshUjJ1fiQLrqqP4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777275790; c=relaxed/simple; bh=pdWlBa1c5DXMjguzXjzpr0Z0NuvDT21nryWpO2V1XLI=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=NO0t5r1qF3WHhaTxLEIPRU2VbMbo+XH7GU5kNmtwaIFHdXSGxZVuZQ+ys+r/cZ4YIoc/6MXB3WdYr4qNgH7dzPC4PHJFYU5qf0TQY7HknaeTWg+TSBoy8WH0PQvV9r0P6jrd6U2r5fWxWCE3Sw6+BO77f8Bcy49tzWxkmvJxlw0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=XYkGSxNz; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XYkGSxNz" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4891f625344so87639685e9.0 for ; Mon, 27 Apr 2026 00:43:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1777275787; x=1777880587; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=oRsAzItervdKnHbuWBjQcpBneMcumUm5p4D7xOs/de4=; b=XYkGSxNziM8cuywwhrHW4PuHNn+8NKwQU+svME9eABXW9IXVzgIE6an6mPmBq3Yvwg uUwwGyfgNliXTpH58GkCX8DBP7n8XJuGnMc6iJRYQEO5us6LH1OvmvWjHq111s8vlVOA VDKLKwQB4vPQ/rHp7sXfuyWHitm/W0g3IR4lyE/kCXdPH3RfxMSPTI2yaKQ6DvWcXn0r QW83tati0m7lsiZ1UCT5FQhwX1r92UW6nHeGpdNgM6ElXaZDtbtLbyLg9rdEI61/6qvC kXS79pcGLPIbWqrMXxix34Fh6NRW8BE932EiUnVImJdij55BE+xLOlQqlgwr8Cb0p3cU 39Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777275787; x=1777880587; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oRsAzItervdKnHbuWBjQcpBneMcumUm5p4D7xOs/de4=; b=P4w6X3Tb+GFSoekj3nt72W2qUkY7vTErYQiSBcvGZcZDPpSyth+RZRXpoZyFryzWnX vuIuRvkZ8dju161ImAwVKBwPhfDis1bN/anrOthZ6nAIpVJyhmmbVrYmgqvk5KlTiJbm DsJZoXQ2e8mtPKuzbyCGgPxpJ/g5aM/CHTTy67RnOuD5BgkqMlYNekP6yEiqmspwBTiy eM9z+7z/2zkw4wHPOMEGW9ejOdcd42RvvPpEqhP+XyZ+0ObApIY52Y9vSr5T2meQuNm3 zcbL7xC4feU0OSU5ET1hrc4KUyM3vgk+5x1HCBtXygrYMTyhT7GvsDk1PaQ6QaaeIZPD ssjQ== X-Forwarded-Encrypted: i=1; AFNElJ+UxE3129p9NwGojuk8aAF7/p9T3FDf/cbOc/gJstH/S3XCXSmqP/ui7BGH8QqRNJ8AgjSQtDjzXnJLClc=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8zUUSToeKSYLEa0UxwMg4itop+pY9FIE74cys6dcbqnwhY2ED VBjbese3tStkUSX2n/SdA4dHeNqcPC0S2FfOt84pmzfrnWGqiDxMqZ1lp9rH1fKlTWM= X-Gm-Gg: AeBDieu0G/j0LWGvIqt8A8z17q/PJscn/Nf+16X7q/QHsaaeQE8AQWwnZanG2VtPefi y4n8ZKvLD3qDDBvouiJHmR0KIQ96B9faYGzgExUy6KG1bAA794Y4+X/uAsfMJQwwGE1AHCcUpWe coCOerMCXDgXcNSQBiIVgruFu3+2BJ7NhmQG15L/C6ceJbqrJ1g1Ym9krIMAoTgrDnPWvLxUOpn zE/zZUAWjT5m0HRbORRHrfDskUwRquZfobzj7BpHn9wQO+8vT1YpNpN60mYcBmZ7h808aoa0btJ SEEs24n9TwhxY04PPai1CUQpI1gNxpxACkeURZR3nkeHkgQ2Q8QoB4Rrqa1gkPV2FX+UlR6/Ulc mctGurkPiHKlO/zkaanwgSw1CFjeNDOwM7W83XxjesFZvrFYQ1jswLwoIeS2UQgLGvcqHLuI142 1qVyAHh2fJpFddzNWMamSs57IrKQrjCh0/zi1Dx7ReNuuo78+tb5jIoRdOn4PNzg4Mqu+AbBlcz AGacAscE6AvgM2/uA== X-Received: by 2002:a05:600c:1d05:b0:489:1baf:8c03 with SMTP id 5b1f17b1804b1-4891baf8d2cmr428569415e9.11.1777275786796; Mon, 27 Apr 2026 00:43:06 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:ad59:75f7:6c30:2440? ([2a01:e0a:106d:1080:ad59:75f7:6c30:2440]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a6124d7e7sm462203655e9.5.2026.04.27.00.43.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Apr 2026 00:43:06 -0700 (PDT) Message-ID: <503bdbd2-8a88-4224-8059-23e9e5c599f7@linaro.org> Date: Mon, 27 Apr 2026 09:43:08 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH] drm/panel: feiyang-fy07024di26a30d: return display-on error To: Christian Van , Jagan Teki Cc: Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260425053948.117714-1-cvan20191@gmail.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260425053948.117714-1-cvan20191@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/25/26 07:39, Christian Van wrote: > mipi_dsi_dcs_set_display_on() returns an error code, but feiyang_enable() > currently ignores it and always reports success. > > Return the DCS command result so callers can observe enable failures. > > Signed-off-by: Christian Van > --- > drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c b/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c > index 4f8d6d8c0..dbdb7e3cb 100644 > --- a/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c > +++ b/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c > @@ -98,9 +98,7 @@ static int feiyang_enable(struct drm_panel *panel) > /* T12 (video & logic signal rise + backlight rise) T12 >= 200ms */ > msleep(200); > > - mipi_dsi_dcs_set_display_on(ctx->dsi); > - > - return 0; > + return mipi_dsi_dcs_set_display_on(ctx->dsi); > } > > static int feiyang_disable(struct drm_panel *panel) Reviewed-by: Neil Armstrong Thanks, Neil