From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50E1C37C0F0 for ; Tue, 17 Mar 2026 20:29:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.9 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773779395; cv=fail; b=SVged7m/s7jET+VLnSRvYumnZxhkpn00/ko71nBXCq0U8h1Kkj4qhJO4eU6ZLSHNjh4IFRV7YQRjRtIAeUQUt5oFb/L0xGBv+otpXuppc2PP2seJFIjPYQZxgecgJ8+8KGzbGCFaDZt/fqnCRJ9WtUx57QL4hkTC2gb/jsfm+Tc= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773779395; c=relaxed/simple; bh=CxxM0uECH8AyyIu2z0uVofLXie/QC+7Gr0IG2TQdBjY=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=F0vdTogd86pjSQVZFz5u4ns5gXYSafXIDXpN3YDC8y9xhYrmh+B08ntGZ5YlrMfxYjwOSGUODj8EC2i2n3iZ3iMTCg00EfXU6CUrzo8NuopnsTWMB1BjN5s9tI/OPD4UOoFhzT7QAZm8xCuS0JNFUW7Oz4zWT0j3twOraLMj1Pg= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=MixS8x1Z; arc=fail smtp.client-ip=192.198.163.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="MixS8x1Z" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1773779392; x=1805315392; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=CxxM0uECH8AyyIu2z0uVofLXie/QC+7Gr0IG2TQdBjY=; b=MixS8x1ZfmV3OV1uSwXJXI/9chCiIw5o6KDyQHZ9Y0CQfaFp0gdXAC3r CqQb1fbVUT8OIIOGXEp/JD+zwUEr9qI0giS3m8KCgai/fgi2uuSOX6J+W hvQ3akxlpXcWUoIaqkKjszlorq0Q+6o+DCp/Zl+AgbbdWJ7D/FIzDHpga SxvHZXvp+//SDuwPyugY66SpDxFDGmgRnSWN8adkuRFDhDxwxirskoV5S WFwVNp7x7NCXFuQWLkZAwwiIheIuviL5eoZvP0S7iUBIGKdnX3far1J1K g0vTb9otxvrXOcuLc2Ac7+HxU8FrqpiLYZgBS1QJD7iygvAKkMX1jlmVk A==; X-CSE-ConnectionGUID: 6YcFwrZsSfSCQJoddB1Szg== X-CSE-MsgGUID: 91uubhtyR6auW+r7bHhGaw== X-IronPort-AV: E=McAfee;i="6800,10657,11732"; a="85521230" X-IronPort-AV: E=Sophos;i="6.23,126,1770624000"; d="scan'208";a="85521230" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2026 13:29:52 -0700 X-CSE-ConnectionGUID: KubPGuRhStu+XG0hWJeifg== X-CSE-MsgGUID: BShp1OvtS7GnTsyCe6OIWA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,126,1770624000"; d="scan'208";a="219866050" Received: from orsmsx903.amr.corp.intel.com ([10.22.229.25]) by fmviesa008.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2026 13:29:51 -0700 Received: from ORSMSX903.amr.corp.intel.com (10.22.229.25) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 17 Mar 2026 13:29:50 -0700 Received: from ORSEDG902.ED.cps.intel.com (10.7.248.12) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Tue, 17 Mar 2026 13:29:50 -0700 Received: from MW6PR02CU001.outbound.protection.outlook.com (52.101.48.60) by edgegateway.intel.com (134.134.137.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 17 Mar 2026 13:29:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dTCZI9sE1Q8moW/eeb4eKuEoNxqEgdJyCNpIYv3VEV12lbxg+MQ9pYQU6CDsLSMjZ0pdtE9U5FyKS8r+xDkC+bkTga7QNA2I8Y7aICFKPLSa+AL/OLYM1OdB9BeaM9jKJUm56qZma6aXRvmBh5JKxLG59GVnSCNJCSiiIbxY7em2QmFv7/cG+vXY/6b0qNwqMIIT2M0BxyL/sjxjavB4C1m2gpi3BCTji4JcUfh9TZLV+PnnwBznlDAeOGV77CQeYuIZ0G82EphH0hCUD61WyhCCeavZ3W85psq/XwWL+uVkKMcxKpJ9gwZn5pThhC0dqIl0fdsABcmz4oQGM3IgdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F0i1pwWAzfNt6IQ2FFVKDqR5fr4NkV4bB7PFE9nSj0E=; b=jmpj56JxZAoMiXIoDkl+k8DTysQafrwXvJKtWKXEVCBuLydPtbAiA2t7tlh0WxwN6rw79TvP1PK9PCDrpsHKSteJoEE58J/w4twAm0zV3S6tWG9p9vrxJaY9E1PEXbJ2MARIH5cbx6SoTagL8B/8RVmHQItmOJy2RGz5em2jRlwwRP+HB6va4cDv1YZI96H2U8GWCfUGS4FlXXGzvtLaGJ+ZkmuCU+2fKR1/h1Y94jhFEdI1VAWkTBbaPpBrK/eQLOCBOKw+OgG99Q8nobMinniql5Tr6Z8u9R3Sn04dBArmYoM2c3RnyZ1S5cpP8WZXSdKG0yqW+bipXYnHErjDGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7997.namprd11.prod.outlook.com (2603:10b6:8:125::14) by MW5PR11MB5860.namprd11.prod.outlook.com (2603:10b6:303:19f::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9723.19; Tue, 17 Mar 2026 20:29:48 +0000 Received: from DS0PR11MB7997.namprd11.prod.outlook.com ([fe80::24fa:827f:6c5b:6246]) by DS0PR11MB7997.namprd11.prod.outlook.com ([fe80::24fa:827f:6c5b:6246%4]) with mapi id 15.20.9723.014; Tue, 17 Mar 2026 20:29:48 +0000 Message-ID: <5041430d-7915-488a-b102-67a30e7b4b07@intel.com> Date: Tue, 17 Mar 2026 13:29:44 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 2/3] x86/cpu: Check if feature string is non-zero Content-Language: en-US To: Maciej Wieczor-Retman , , , , , , , , , , , , , , , , CC: , References: <92b57f62940b1972d39ae270b1b1ea497462c9ec.1773771353.git.m.wieczorretman@pm.me> From: Sohil Mehta In-Reply-To: <92b57f62940b1972d39ae270b1b1ea497462c9ec.1773771353.git.m.wieczorretman@pm.me> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BY5PR13CA0021.namprd13.prod.outlook.com (2603:10b6:a03:180::34) To DS0PR11MB7997.namprd11.prod.outlook.com (2603:10b6:8:125::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7997:EE_|MW5PR11MB5860:EE_ X-MS-Office365-Filtering-Correlation-Id: a550385b-e7d7-4fe3-df79-08de8463ef16 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024|22082099003|18002099003|56012099003|921020; X-Microsoft-Antispam-Message-Info: 3fyxaGg5FxDGbUpX/7QvCvR6lNPPMp1dWhyPP63teRKkKBH6oNxEmhU1CZCBs/oFQV9sSVCIaz/XW2l4VSh9xte28sCU8szqSNX1QOrO4b7dVvdqIcAcHg0qisC2qSr7NCXMM3dXgBZaPiEuGx1L1EeZI9+2UkAynv9h3yUQ3dnRkEsYcDEzqOuvzBx1u2mO50LXOF2OpeFTE2o5BoOs1ipYX2Zs9/PesZgtJ9OrBIlOVL284dlBPEtrjM/m8z0dXKN/kkNXUO1lJQ34dR77yD4p+yfozbX47shc/YV7ANDk6g2Oqxphz3PFxs7THG6vtce2Bu6F7N5VIv6Zm73/AwaOaQABLbuIU+On9sq780nlO6k1pFKb6ns2fyzSt9Zz/0cFvHIgnJui2Y0qlq00qB08LC/9hTJkEK3Q9odpFiOHZsnL+9mtrufePH11W+kVObv8PZz8ew2AtHQIQbqomw0R0nJNnHHjk5kj0n9AD+5w0SAF5HihvHY0tbXhAji7j+NeFAjvkRWRi05uukBRb9S7jnJkq65gEtaF2W4qfDSKm7JIja91bwhj2dXRkWmhY/OMdkue2+VgLDeaZLIF3d1ILTWSgnXQgYTFWG8Hb5+5e05Wu0hl7rvkBt5h5fylJbIBylg+9YrIDKnGdMbi0+luBzzRkIA0M1O68I7pKhAIBGRvkacel71m9ro4+CSjo0wzVBqpH8Je92uHeYOZGXN6zQz6tVOs/QgdslcSi7NyH+W3EUg/12DDCB9pXWLCimXp3dLxbKFm8BxlxY/EaA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR11MB7997.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024)(22082099003)(18002099003)(56012099003)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RFRWdGIxNXVucGdlODRaWnpzN3VXTHhGYWFYbEtLbXhWMTQ4R1pYWUpVbzlQ?= =?utf-8?B?S01sOStmakt0RDZNWUhBUFk4K2ZqdGFSZVlTL2k0OW8yYXhhZDl0bjBVb2Nk?= =?utf-8?B?WXNNWUtQcTlsWXpSL0UwZ0ZwZ3Z1bVNuV1ZOYVBNZVJJNEJUT2MwcmtySEdH?= =?utf-8?B?NEFibFBuZ2J0NDY2SmFRZFBwTm5VaWhJWGd1empCTXBzelBmY0MxbDhBM2JH?= =?utf-8?B?c1VCV1NCL09vR3JTT2xJYnVlME1oaXNpa1lxWWZCb1ZEOWRjcjlrUDRybExT?= =?utf-8?B?OFNuRHQ1bnRMc2pGZDlOdy9wckRtc0NOY2tid3U4QkhTbDRRdHd5SjA3RTlo?= =?utf-8?B?bkZObTlMZit2QnBqSmVEYkFPVWVjeXpYci9LZGw2OTF3TWlWNW01WGhOZm15?= =?utf-8?B?eTF0cUVwRU85aGoxazMzY2w0S1kwSGVWZzdjOFR6R3NEZjNuVmNteGlkVTdI?= =?utf-8?B?SERpc0tYbHd6L2hEWTVzVnQ1NStSLzFYNzdvMkplczA0QnhjOE95NHNvR1lZ?= =?utf-8?B?cHlhUXMzL3VPd09EY1F2enNFbWVEaStUOTRpRDRMNElIdWtOL215dVFQUnI5?= =?utf-8?B?WHYrSVliMDJPVUI4T0d1U2dyVDA1RzNtTHpWUlNXb3cvNzFXN0o3dnZNSG5o?= =?utf-8?B?VXljNm85RlBWbDI2eTV3QTJLK0kzRlpsWXFPOWRNcTJHcTJEUE9GQm12eXNK?= =?utf-8?B?TlNGZjdJclhpckx4dXJ2N2tlT29PYytmV3lkMlFIQ0FlR0E3Y0xjdktRc0hW?= =?utf-8?B?TEJOTlo5UHZMcmdJTjc0K0dSc2Nua1Z5QmQwT0hxcnk3aWVRRUJObTlTSFJD?= =?utf-8?B?Sng5OXVFVUI1SzBqYWExRytHWW0xRTZ0MWZWTUhvWnNYaFRZaHovK0lkR25M?= =?utf-8?B?bUVQWnhkeUk3NjY2NjA1NmlXeVVaODlJNUwwSW5WRktKa2UzNjY0dDlLOWhS?= =?utf-8?B?MDIreHcyMmFBVlFmVGx4bmNReVBOYWR3VXJ2UGxPWXdmb2FYY0xBNHd6T1V4?= =?utf-8?B?ZlJlWks4ZWtDU24zVW5HSTE4UDJ3cW1Ra0VGNmN0UG9pWlJYSE5XNHB6MCt6?= =?utf-8?B?SWVwdHpFMHNaY05xSUEzb09IZXdVZUE4cmhtOG5Edlo0Q1FkcjFVekU4WHM5?= =?utf-8?B?RC9pci81Q2gwc0E2WHIzUExtSmt6Y0EyRGRMdWNmSlZsYkN5amNwV1lvYkR4?= =?utf-8?B?ZjlNQTArMnZxTlNiMWluMEd5cWQyd0pnUTQxdFh0YzVyVlRYZEQ2S3pwdklj?= =?utf-8?B?eFN5VXRzRER4MDJDRzAvSGtwUVIzY3JyZmgzZVkxSW5jQWVZeFF6ZEgxc0pR?= =?utf-8?B?T2FmMEhrcEhrK0IxR2t6cGpCM0J1ZmUyc2lJSDYvQnBLcFRBTFhxYUVzRXRT?= =?utf-8?B?c2VHdkg3SUFzV1dVMy9VRWYrSDZBVElvTGp6aTZFalRWY24zT3RuUDJ4WU0v?= =?utf-8?B?elFINGNGZjZpS3AzRGE2OGRoUmVDZ0JrL0JSK2huVTArelR5WGxaTDlITDhC?= =?utf-8?B?eSsxK0wwcVFCcHRVSEFXeERxTVcyZTRnMTRBUWpja3lCd2pvY0djTWpyNjhI?= =?utf-8?B?aXhCRmhFUC9UT3V2NzRZWVVKYktEa2ZocFVuVUJaaHVIdFdXNmxlMDlrb1JI?= =?utf-8?B?bGljd1FLSTBEbU9aVThsUEpvUlYvNWg1WGZMZTRnVjdvT01rTTNoaWNLNVBx?= =?utf-8?B?V3dFbHoyTmZPRW1DRWtXbjJydWFjR0VTYmVIRjBva3Rnem1DVDZSdUdRaCtK?= =?utf-8?B?cWwwMnhSNDZySVRYSVhFd1pVOFB6NEQ5L0Z5cUpKbko2WHNITDVBYWlyNFNJ?= =?utf-8?B?UzdEbXUvQWMwUEZnUUFONHdvTDVqeDBLUVExeWEvc2JpTE5wTjE1bE8yUGpW?= =?utf-8?B?Y1BlU1BYelRIWlhoWEZGRnYwMUlVbGNSOXVONTNsNFlMMnRzSzVXQW9uS0Ez?= =?utf-8?B?SHQzMW83V3MxZ0MxZ0VEZU55U0svTy9Vdk1tRHpGRE9PQVJqeXdLM1BHYUtv?= =?utf-8?B?RGpoeGtyS1N3VXFnYkpZTVVLQ0FsVERkY2hLbnRXbCtWc1dxdUZkUllXQzNz?= =?utf-8?B?cWc5MzFmWERLUkxQNkpxL0JpNXQ4TGN5K21RNkdoU1IzREZLREpQKzdwblhw?= =?utf-8?B?bGpvS3I1RGszZmFjNjRuUmZUQkhNQXpPbVpMOGJoZWdrdjcraVNhOUxFaHl0?= =?utf-8?B?eWZWWlorVnYydjFUSFl5NU9Kam0zdVJ2eFpGTEdFeWxmK2ZIQ3EwUDI4cTBu?= =?utf-8?B?KzM2eHRuQzU5dEk2U3lXcXhjSU1PQ3F2NlREZE4yYzU5dWR0bUM3T240ckp0?= =?utf-8?B?bnpJcGxXeWZ3SjhCR295V1lpYThlcDlKdlhtd2NqRTZiaUhRMGlmUT09?= X-Exchange-RoutingPolicyChecked: Cnicuhhx1bvlET/WZI+9GP7Wgz0TKkb2cR5n6uIkbQLjMm08YQCV3if5U3j2u8eVvvXi1kJ7q5YlyEvSbs+6HSZCNegSZIHV7TPMXSmcW2zLCE7L/u7A0cuctgjqBr919w4K/7ggPNs0kbwItxpTDeyDcZ91yFl3UUZ1hu9cxFj+WMA+/RgynW4vyumOpulBa+cPUHS8f/z9B7WLOFJhCM/w8VnfWB6JYdDUxPsFDVycskhAPpBqfXbuwBFF0tMpTIoDxiJ++P2LaEo61qy0nGdmS7dmOfra//69VdySUe8S7F+OOsvmMWX9DQPwyxWApW88sy5RnmpBbFEp+uO1xA== X-MS-Exchange-CrossTenant-Network-Message-Id: a550385b-e7d7-4fe3-df79-08de8463ef16 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7997.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2026 20:29:48.2618 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tEuiL8TM/ZNqz7xshLFi4Rza5SiI5ePssRvWSJB8/2RcR2u4NaGULnIxz+JcPHQjpnKCbU22HgMM3K5h0stdJA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR11MB5860 X-OriginatorOrg: intel.com On 3/17/2026 1:00 PM, Maciej Wieczor-Retman wrote: > From: Maciej Wieczor-Retman > > In filter_cpuid_features(), x86_cap_flags[] is read, but it's not verified > whether the string is non-zero which could lead to unwanted output. > > In two more places there are open coded paths that try to retrieve a > feature string, and if there isn't one, the feature word and bit are > returned instead. > > Add a common helper to fix filter_cpuid_features() as well as clean up > the open coded cases. > > Signed-off-by: Maciej Wieczor-Retman > --- Reviewed-by: Sohil Mehta