From: Tejun Heo <tj@kernel.org>
To: Qiurong Fang <fangqiurong@kylinos.cn>
Cc: Tejun Heo <tj@kernel.org>,
arighi@nvidia.com, void@manifault.com, changwoo@igalia.com,
sched-ext@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] selftests/sched_ext: Test that ops.dequeue() can iterate the consumed DSQ
Date: Wed, 16 Sep 2026 11:01:32 -1000 [thread overview]
Message-ID: <5044e1c6b6468239b8629e9a2fa8a919@kernel.org> (raw)
In-Reply-To: <20260916070753.3343113-3-fangqiurong@kylinos.cn>
Hello, Qiurong.
On Wed, Sep 16, 2026 at 03:07:53PM +0800, Qiurong Fang wrote:
> + * ops.dequeue() of this scheduler iterates the user DSQ tasks are
> + * consumed from with bpf_iter_scx_dsq, which takes the DSQ lock.
"the user DSQ it consumes tasks from" reads easier.
> + SCX_FAIL_IF(pthread_create(&tid, NULL, run_workload, skel),
> + "Failed to create workload thread");
> + pthread_join(tid, NULL);
The thread doesn't add anything. Poll from run() directly. Its own wakeups
are the workload.
Thanks.
--
tejun
prev parent reply other threads:[~2026-09-16 21:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 7:07 [PATCH v3 0/2] sched_ext: Don't run ops.dequeue() with a DSQ lock held Qiurong Fang
2026-09-16 7:07 ` [PATCH v3 1/2] " Qiurong Fang
2026-09-16 21:01 ` Tejun Heo
2026-09-16 7:07 ` [PATCH v3 2/2] selftests/sched_ext: Test that ops.dequeue() can iterate the consumed DSQ Qiurong Fang
2026-09-16 21:01 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5044e1c6b6468239b8629e9a2fa8a919@kernel.org \
--to=tj@kernel.org \
--cc=arighi@nvidia.com \
--cc=changwoo@igalia.com \
--cc=fangqiurong@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=sched-ext@lists.linux.dev \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®