mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Fa-Iz Faadhillah Ibrahim <faiz.faadhillah@gmail.com>
To: jlee@suse.com, basak.sb2006@gmail.com, rayanmargham4@gmail.com,
	Armin Wolf <W_Armin@gmx.de>
Cc: kuurtb@gmail.com, ilpo.jarvinen@linux.intel.com,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/4] platform/x86: acer-wmi: Add fan control support
Date: Fri, 17 Oct 2025 00:23:19 +0700	[thread overview]
Message-ID: <5048620.31r3eYUQgx@cacher> (raw)
In-Reply-To: <20251015192551.321200-1-W_Armin@gmx.de>

On Thursday, October 16, 2025 2:25 AM Armin Wolf wrote:
> This patch series aims to add fan control support to the acer-wmi
> driver. The patches are compile-tested only and need to be tested
> on real hardware to verify that they actually work.
> 
> I CCed three users who requested support for this feature. I would be
> very happy if one of you could test those patches and report back.
> 
> Changes since v2:
> - get rid of nested bit masks
> 
> Changes since v1:
> - remove unnecessary blank line
> 
> Changes since RFC v2:
> - improve error handling when setting fan behavior
> - Add Reviewed-by tags
> - whitelist PHN16-72
> 
> Changes since RFC v1:
> - remove duplicate include and replace hwmon_pwm_mode with
>   hwmon_pwm_enable in second patch
> 
> Armin Wolf (4):
>   platform/x86: acer-wmi: Fix setting of fan behavior
>   platform/x86: acer-wmi: Add fan control support
>   platform/x86: acer-wmi: Enable fan control for PH16-72 and PT14-51
>   platform/x86: acer-wmi: Add support for PHN16-72
> 
>  drivers/platform/x86/acer-wmi.c | 292 +++++++++++++++++++++++++++++---
>  1 file changed, 269 insertions(+), 23 deletions(-)
Hello,

I've tested the patch on my PHN16-72, this time the fan control for CPU fan 
works just fine, but GPU fan control doesn't work anymore. no logs observed on 
dmesg while changing the speed of either fan.

Thanks,
Fa-Iz Faadhillah Ibrahim 




  parent reply	other threads:[~2025-10-16 17:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-15 19:25 Armin Wolf
2025-10-15 19:25 ` [PATCH v3 1/4] platform/x86: acer-wmi: Fix setting of fan behavior Armin Wolf
2025-10-15 19:25 ` [PATCH v3 2/4] platform/x86: acer-wmi: Add fan control support Armin Wolf
2025-10-15 19:25 ` [PATCH v3 3/4] platform/x86: acer-wmi: Enable fan control for PH16-72 and PT14-51 Armin Wolf
2025-10-15 19:25 ` [PATCH v3 4/4] platform/x86: acer-wmi: Add support for PHN16-72 Armin Wolf
2025-10-16 17:23 ` Fa-Iz Faadhillah Ibrahim [this message]
2025-10-16 18:01   ` [PATCH v3 0/4] platform/x86: acer-wmi: Add fan control support Armin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5048620.31r3eYUQgx@cacher \
    --to=faiz.faadhillah@gmail.com \
    --cc=W_Armin@gmx.de \
    --cc=basak.sb2006@gmail.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jlee@suse.com \
    --cc=kuurtb@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rayanmargham4@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®