From: Randy Dunlap <rdunlap@xenotime.net>
To: Aristeu Rozanski <aris@redhat.com>
Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
Tejun Heo <tj@kernel.org>, Li Zefan <lizefan@huawei.com>,
Hillf Danton <dhillf@gmail.com>,
Lennart Poettering <lpoetter@redhat.com>,
Hugh Dickins <hughd@google.com>
Subject: Re: [PATCH v2 2/2] fs: add missing documentation to simple_xattr functions
Date: Thu, 13 Sep 2012 11:02:14 -0700 [thread overview]
Message-ID: <50521FA6.7040900@xenotime.net> (raw)
In-Reply-To: <20120911202810.725043407@napanee.usersys.redhat.com>
On 09/11/2012 01:28 PM, Aristeu Rozanski wrote:
+/**
+ * simple_xattr_set: xattr SET operation for in-memory/pseudo filesystems
The format for the function name/description uses '-', not ':', as:
* simple_xattr_set - xattr SET operation for in-memory/pseudo filesystems
+ * @xattrs: simple_xattr list
+ * @name: name of the new extended attribute
+ * @value: value of the new extended attribute. If NULL, will remove the
+ * attribute
Missing @size parameter description.
+ * @flags: if XATTR_CREATE is set, no already existing extended attribute may
+ * exist. If XATTR_REPLACE is set, the extended attribute should exist.
+ *
+ * returns -ENOMEM for allocation failures, -EEXIST in case XATTR_CREATE is
+ * set in flags and an extended attribute with the same name exists,
+ * -ENODATA if XATTR_REPLACE is set in flags but no entry with the
+ * specified name exists.
*/
int simple_xattr_set(struct simple_xattrs *xattrs, const char *name,
const void *value, size_t size, int flags)
--
~Randy
next prev parent reply other threads:[~2012-09-13 18:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 20:28 [PATCH v2 0/2] cgroups: add documentation on extended attributes and " Aristeu Rozanski
2012-09-11 20:28 ` [PATCH v2 1/2] cgroups: add documentation on extended attributes usage Aristeu Rozanski
2012-09-12 1:26 ` Li Zefan
2012-09-11 20:28 ` [PATCH v2 2/2] fs: add missing documentation to simple_xattr functions Aristeu Rozanski
2012-09-13 18:02 ` Randy Dunlap [this message]
2012-09-13 18:11 ` Tejun Heo
2012-09-13 18:23 ` Aristeu Rozanski
2012-09-11 21:31 ` [PATCH v2 0/2] cgroups: add documentation on extended attributes and " Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50521FA6.7040900@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=aris@redhat.com \
--cc=cgroups@vger.kernel.org \
--cc=dhillf@gmail.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=lpoetter@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®