From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752169Ab2IPJ7F (ORCPT ); Sun, 16 Sep 2012 05:59:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14478 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751477Ab2IPJ7D (ORCPT ); Sun, 16 Sep 2012 05:59:03 -0400 Message-ID: <5055A2E2.9080003@redhat.com> Date: Sun, 16 Sep 2012 12:58:58 +0300 From: Avi Kivity User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0 MIME-Version: 1.0 To: Xiao Guangrong CC: Marcelo Tosatti , LKML , KVM Subject: Re: [PATCH v2] KVM: trace the events of mmu_notifier References: <50499123.70609@linux.vnet.ibm.com> <504DAE34.1060402@redhat.com> <504DB22F.4020609@linux.vnet.ibm.com> <5052C7DD.4000205@linux.vnet.ibm.com> In-Reply-To: <5052C7DD.4000205@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/14/2012 08:59 AM, Xiao Guangrong wrote: > On 09/10/2012 05:26 PM, Xiao Guangrong wrote: >> On 09/10/2012 05:09 PM, Avi Kivity wrote: >>> On 09/07/2012 09:16 AM, Xiao Guangrong wrote: >>>> mmu_notifier is the interface to broadcast the mm events to KVM, the >>>> tracepoints introduced in this patch can trace all these events, it is >>>> very helpful for us to notice and fix the bug caused by mm >>> >>> There is nothing kvm specific here. Perhaps this can be made generic >>> (with a mm parameter so we can filter by process). >> >> Hmm, i would like to put these tracepoints in the mmu-lock then we can clearly >> know the sequence between mm and kvm mmu. It is useful for us to detect the >> issue/race between them. >> > > Ping...? Sorry. Yes you are right, knowing the exact sequence is valuable. Yet it will be hard to associate these events with the mmu since we don't have gpas there. -- error compiling committee.c: too many arguments to function