From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AED53E9C38; Fri, 22 May 2026 11:43:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779450208; cv=none; b=geQc1yuiRI+hRs7OcvNNRXHvzr9vhYDfGnl+Npqx5eoToMHKDZk+TUsxFFcdESVsVCRmWw19UQfwjAP9KkKHFqbX5ImsByp4k0pZXlqMsrcGWihYdEUOWtZdbulf+gBiGwXENQMmP1rZLtqoXjDRgDG4WEI1isFAVzAi1a2x1e8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779450208; c=relaxed/simple; bh=8WpTRcQO/IgPOpBDqRtRGj7UBjUYFhF2L3Whv938fjM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kpryNZsYPF3RZfCESou4xkN9T9T2CG0tUOSCJgPJ0BYfGiGlM2t/x705AUMrvdJ9GjwGQwz6SqHgJzT+5bPDYR6QQD0pSL0VS/KfZ5iwsIg0xyYEwLWpOJ/51gE3th08oET9/cCOejfXnKD5G3PdsDMXXkgDM5K1wbX+da+vdJw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=jAfcrYRP; arc=none smtp.client-ip=117.135.210.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="jAfcrYRP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Message-ID:Date:MIME-Version:Subject:To:From: Content-Type; bh=aZUEdcyM5Q3+qMbv3hetw4h0VjYXtXLqYRvej9znfhA=; b=jAfcrYRPcLLhccYSxJIcBY9q8tkK9e2nsaEwd35F24gEFh6/eUgeM2kbE66z3Z aWMOg+q9cXZAYTVYzt9pk9NZOJwzyWWOoBltIWwSej82p5Sz6YGld3kDPozKS64h 9ZhVjPiuwUf8DbqTmpi5qy6OihnMwjG+VyiD0PtitAx9o= Received: from [192.168.50.71] (unknown []) by gzga-smtp-mtada-g1-0 (Coremail) with SMTP id _____wC3jMtFQRBqb5PoCg--.19080S2; Fri, 22 May 2026 19:43:01 +0800 (CST) Message-ID: <5057dfda-0604-45ce-8fb1-fbf99c51bf75@163.com> Date: Fri, 22 May 2026 19:43:01 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] PCI/VPD: Add Realtek 8126 to VPD blacklist To: bhelgaas@google.com Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260522114135.2104890-1-18255117159@163.com> Content-Language: en-US From: Hans Zhang <18255117159@163.com> In-Reply-To: <20260522114135.2104890-1-18255117159@163.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CM-TRANSID:_____wC3jMtFQRBqb5PoCg--.19080S2 X-Coremail-Antispam: 1Uf129KBjvAXoW3ZF4UZFyUGw1kAw1Utr48Crg_yoW8JF45Xo W7twn7tan3Gr1UC3yIkw4xAan7AryxKan3Aw45Krs8tw17Cr4Yqw4qva1Sg39rAFW8X3y7 X34Igrn5G3yqqrn7n29KB7ZKAUJUUUU8529EdanIXcx71UUUUU7v73VFW2AGmfu7bjvjm3 AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvjTiU3yNUUUUU X-CM-SenderInfo: rpryjkyvrrlimvzbiqqrwthudrp/xtbC6wUAo2oQQUVjLQAA39 Hi Bjorn, Add log: hans@orangepi6plus:~$ lspci 0000:60:00.0 PCI bridge: Device 1f6c:0001 0000:61:00.0 Ethernet controller: Realtek Semiconductor Co., Ltd. Device 8126 (rev 01) 0001:30:00.0 PCI bridge: Device 1f6c:0001 0001:31:00.0 Ethernet controller: Realtek Semiconductor Co., Ltd. Device 8126 (rev 01) 0002:c0:00.0 PCI bridge: Device 1f6c:0001 0002:c1:00.0 Non-Volatile memory controller: Kingston Technology Company, Inc. NV2 NVMe SSD TC2200 (DRAM-less) hans@orangepi6plus:~$ hans@orangepi6plus:~$ sudo dmesg -C [sudo] password for hans: hans@orangepi6plus:~$ sudo lspci -s 31:00.0 -vvv 0001:31:00.0 Ethernet controller: Realtek Semiconductor Co., Ltd. Device 8126 (rev 01) Subsystem: Realtek Semiconductor Co., Ltd. Device 0123 Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx+ Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- SERR- Kernel driver in use: r8169 hans@orangepi6plus:~$ hans@orangepi6plus:~$ sudo lspci -s 61:00.0 -vvv 0000:61:00.0 Ethernet controller: Realtek Semiconductor Co., Ltd. Device 8126 (rev 01) Subsystem: Realtek Semiconductor Co., Ltd. Device 0123 Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx+ Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- SERR- Kernel driver in use: r8169 hans@orangepi6plus:~$ hans@orangepi6plus:~$ lspci -t -[0000:60]---00.0-[61]----00.0 -[0001:30]---00.0-[31]----00.0 -[0002:c0]---00.0-[c1]----00.0 hans@orangepi6plus:~$ hans@orangepi6plus:~$ lspci 0000:60:00.0 PCI bridge: Device 1f6c:0001 0000:61:00.0 Ethernet controller: Realtek Semiconductor Co., Ltd. Device 8126 (rev 01) 0001:30:00.0 PCI bridge: Device 1f6c:0001 0001:31:00.0 Ethernet controller: Realtek Semiconductor Co., Ltd. Device 8126 (rev 01) 0002:c0:00.0 PCI bridge: Device 1f6c:0001 0002:c1:00.0 Non-Volatile memory controller: Kingston Technology Company, Inc. NV2 NVMe SSD TC2200 (DRAM-less) hans@orangepi6plus:~$ hans@orangepi6plus:~$ lspci -n 0000:60:00.0 0604: 1f6c:0001 0000:61:00.0 0200: 10ec:8126 (rev 01) 0001:30:00.0 0604: 1f6c:0001 0001:31:00.0 0200: 10ec:8126 (rev 01) 0002:c0:00.0 0604: 1f6c:0001 0002:c1:00.0 0108: 2646:501d hans@orangepi6plus:~$ sudo dmesg [ 75.455657] r8169 0001:31:00.0: invalid VPD tag 0x00 (size 0) at offset 0; assume missing optional EEPROM [ 81.458811] r8169 0000:61:00.0: invalid VPD tag 0x00 (size 0) at offset 0; assume missing optional EEPROM Best regards, Hans On 5/22/26 19:41, Hans Zhang wrote: > The Realtek 8126 Ethernet controller advertises VPD capability but > returns invalid data when VPD is read, leading to kernel messages > like: > > r8169 ... invalid VPD tag 0x00 (size 0) at offset 0; assume > missing optional EEPROM > > and pcilib reporting "sysfs_read_vpd: read failed: No such device". > > Add the device to the VPD blacklist to suppress these errors. > > Signed-off-by: Hans Zhang <18255117159@163.com> > --- > drivers/pci/vpd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/vpd.c b/drivers/pci/vpd.c > index 153394a652d3..fbc34cd842ac 100644 > --- a/drivers/pci/vpd.c > +++ b/drivers/pci/vpd.c > @@ -590,6 +590,7 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_LSI_LOGIC, 0x002f, quirk_blacklist_vpd); > DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_LSI_LOGIC, 0x005d, quirk_blacklist_vpd); > DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_LSI_LOGIC, 0x005f, quirk_blacklist_vpd); > DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ATTANSIC, PCI_ANY_ID, quirk_blacklist_vpd); > +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_REALTEK, 0x8126, quirk_blacklist_vpd); > /* > * The Amazon Annapurna Labs 0x0031 device id is reused for other non Root Port > * device types, so the quirk is registered for the PCI_CLASS_BRIDGE_PCI class.