mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
To: David Rientjes <rientjes@google.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Konrad Rzeszutek Wilk <konrad@kernel.org>,
	Dave Jones <davej@redhat.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>,
	Suzuki Poulose <suzuki@in.ibm.com>
Subject: Re: [patch for-3.6] fs, debugfs: fix race in u32_array_read and allocate array at open
Date: Fri, 21 Sep 2012 15:52:35 +0530	[thread overview]
Message-ID: <505C3FEB.7030606@linux.vnet.ibm.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1209210216000.18230@chino.kir.corp.google.com>

On 09/21/2012 02:46 PM, David Rientjes wrote:
> u32_array_open() is racy when multiple threads read from a file with a
> seek position of zero, i.e. when two or more simultaneous reads are
> occurring after the non-seekable files are created.  It is possible that
> file->private_data is double-freed because the threads races between
>
> 	kfree(file->private-data);
>
> and
>
> 	file->private_data = NULL;
>
> The fix is to only do format_array_alloc() when the file is opened and
> free it when it is closed.  This means that any thread that holds the
> file open and reads multiple times will see persistent data;

I think you meant we can read data only once. second time onwards we 
don't see any data. (except when fd is forked by child/ races in
threads).


  reply	other threads:[~2012-09-21 10:26 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-18 14:35 3.6rc6 slab corruption Dave Jones
2012-09-18 18:38 ` Linus Torvalds
2012-09-18 18:53   ` Dave Jones
2012-09-19 14:00     ` Raghavendra K T
2012-09-19 17:09       ` Linus Torvalds
2012-09-19 21:27         ` David Rientjes
2012-09-19 21:41           ` Dave Jones
2012-09-18 19:23   ` Konrad Rzeszutek Wilk
2012-09-18 20:24     ` David Rientjes
2012-09-18 20:31       ` Konrad Rzeszutek Wilk
2012-09-18 20:36       ` Linus Torvalds
2012-09-19  0:57       ` Raghavendra K T
2012-09-18 20:35     ` Linus Torvalds
2012-09-18 20:37       ` Konrad Rzeszutek Wilk
2012-09-18 20:49         ` Linus Torvalds
2012-09-19  1:16           ` Raghavendra K T
2012-09-19 19:16           ` Konrad Rzeszutek Wilk
2012-09-19 21:29             ` David Rientjes
2012-09-19 21:49               ` David Rientjes
2012-09-19 23:01                 ` Linus Torvalds
2012-09-19 23:20                   ` David Rientjes
2012-09-20 21:14                     ` Konrad Rzeszutek Wilk
2012-09-20  2:29                 ` Raghavendra K T
2012-09-20  2:46                   ` David Rientjes
2012-09-20  2:55                     ` Raghavendra K T
2012-09-20 21:18                     ` Konrad Rzeszutek Wilk
2012-09-21  9:16                       ` [patch for-3.6] fs, debugfs: fix race in u32_array_read and allocate array at open David Rientjes
2012-09-21 10:22                         ` Raghavendra K T [this message]
2012-09-24 22:26                           ` David Rientjes
2012-09-25  2:54                             ` Raghavendra K T
2012-09-20 12:57                 ` 3.6rc6 slab corruption Raghavendra K T
2012-09-20 21:18                   ` Konrad Rzeszutek Wilk
2012-09-20 12:55             ` Raghavendra K T

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=505C3FEB.7030606@linux.vnet.ibm.com \
    --to=raghavendra.kt@linux.vnet.ibm.com \
    --cc=davej@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=konrad.wilk@oracle.com \
    --cc=konrad@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rientjes@google.com \
    --cc=suzuki@in.ibm.com \
    --cc=torvalds@linux-foundation.org \
    --cc=vatsa@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome