From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751656AbdAaKHh (ORCPT ); Tue, 31 Jan 2017 05:07:37 -0500 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:4038 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751507AbdAaKHa (ORCPT ); Tue, 31 Jan 2017 05:07:30 -0500 Subject: Re: [PATCH 10/17] net: stmmac: Correct the error message about invalid speed To: Corentin Labbe , , References: <20170131091152.13842-1-clabbe.montjoie@gmail.com> <20170131091152.13842-11-clabbe.montjoie@gmail.com> CC: , From: Giuseppe CAVALLARO Message-ID: <505d6fa5-852c-2c18-f940-964ee422d820@st.com> Date: Tue, 31 Jan 2017 11:07:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <20170131091152.13842-11-clabbe.montjoie@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.50] X-ClientProxiedBy: SFHDAG2NODE1.st.com (10.75.127.4) To SFHDAG4NODE1.st.com (10.75.127.10) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-01-31_04:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/31/2017 10:11 AM, Corentin Labbe wrote: > Add 1000 as a valid speed in the error message about invalid speed > in stmmac_adjust_link() > > Signed-off-by: Corentin Labbe > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > index 98f544e..b0154d5 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > @@ -749,7 +749,7 @@ static void stmmac_adjust_link(struct net_device *dev) > break; > default: > netif_warn(priv, link, priv->dev, > - "Speed (%d) not 10/100\n", > + "Speed (%d) not 10/100/1000\n", maybe, it could be "broken speed: %d" peppe > phydev->speed); > break; > } >