From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B505C433DB for ; Thu, 25 Feb 2021 14:45:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3FE4464E28 for ; Thu, 25 Feb 2021 14:45:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232608AbhBYOpQ (ORCPT ); Thu, 25 Feb 2021 09:45:16 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:60296 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232588AbhBYOpG (ORCPT ); Thu, 25 Feb 2021 09:45:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614264217; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bro6K1L61Sgcgif8LOhoB45JhdsJvdKQppn6eGahtEs=; b=gPhWLdv3OI+OeIZMYrQ5ZRZbo+UvgVybX2TzP0laWpswV3wAlPQLZ0KDN0fehyFvOYeOa1 lBcUDJ52lYJX/FSdg0An0PWBMFBKZGLJqfdDOKVNm2wzklW+EZPBHU/K3L5gD5htJR8+2X eJVQUoArcuMDEFRZRhuWSaFtYhZDbJE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-98-ueaSdkpkNOq9pf5i1BRPjg-1; Thu, 25 Feb 2021 09:43:35 -0500 X-MC-Unique: ueaSdkpkNOq9pf5i1BRPjg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B3F2C86A066; Thu, 25 Feb 2021 14:43:33 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-119-68.rdu2.redhat.com [10.10.119.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id 68B6C60861; Thu, 25 Feb 2021 14:43:32 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20210217165058.1336155-1-eric.snowberg@oracle.com> <3524595.1614124044@warthog.procyon.org.uk> <3731128.1614163916@warthog.procyon.org.uk> To: Eric Snowberg Cc: dhowells@redhat.com, Jarkko Sakkinen , =?us-ascii?Q?=3D=3Futf-8=3FQ=3FMicka=3DC3=3DABl?= =?us-ascii?Q?=5FSala=3DC3=3DBCn=3F=3D?= , David Woodhouse , keyrings@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cert: Add kconfig dependency for validate_trust MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 25 Feb 2021 14:43:31 +0000 Message-ID: <506021.1614264211@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eric Snowberg wrote: > > I've added an extra config option to turn on SYSTEM_REVOCATION_LIST sup= port. >=20 > I believe this is ok. However currently, whenever the kernel finds eithe= r a > EFI_CERT_SHA256_GUID or EFI_CERT_X509_SHA256_GUID entry in the dbx, it lo= ads > it into the blacklist keyring. Then anytime signature validation takes > place, these entries are referenced. If there is a match, the signature > check fails. Now with the inclusion of EFI_CERT_X509_GUID, I question why > we want to enable it thru a Kconfig option, when we don=E2=80=99t for the= other two > types. But we do. mark_hash_blacklisted(), is_hash_blacklisted() and is_binary_blacklisted() = do nothing if CONFIG_SYSTEM_BLACKLIST_KEYRING=3Dn. David