From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64FC722CBC0 for ; Sun, 22 Feb 2026 10:41:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771756891; cv=none; b=X33xatIYY4MMIfl2Pyg90ZPpnCXs/dcx7Nok1XpAKXpNLj7B/500OZjfHJKbztz4Mx1pX05sa/AIVUPaPWkHNPxApLZnblJ4p+H0QV0WrB+feYze94ltak/NnysmKCriIvfR0iCiQ7EBI9Y2iOb7gkTv5Eb+acQ+lgtc+8wfEHQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771756891; c=relaxed/simple; bh=FiNNBmyLQdXBFATIDB0b8nfQtkqDYNQ9fPbTqEZkvYU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=n9ArcozE/kEbE9azM8M6QDGyMYhnc0cwtOKu+GBftTI26aK/yylpeW3fgIG2RzlwPNQRw2921rgHz/McEfgPDgHlyrsHCoPUbFYJvYL8wO+ykNkDLa017XCh0rbehyEbFP41u37ZAqQ/q4TQabCzA1O/G2KrXDpQesFktElZx5o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=INTO7122; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="INTO7122" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-48375f10628so20814825e9.1 for ; Sun, 22 Feb 2026 02:41:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771756889; x=1772361689; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=t98mLj8w4amE5ycgxlNBP+sdq7EJCJ2CztJb+0KFU28=; b=INTO7122p++mLbYa/2x98TGl1Q3dMkNRu7wBEownErQzzFONbO4WufoQeMSuKJOn9y /kS38GI1kl/irzqn6v4wGwgxWGey6O9V/DEBQrRfjF50ZVmWlHRWSHcizhkP+yyXfRyW hVTUCU6AF9u480zyJtlq/8P3BB3jeexsegjL2WeZI4pkM/Z36OaJzQ9HN3mmQ7GNJgug /Ls/IDBCnsEzjuEawuSwbjQaQ+M4dzvcL22jn67bP6QuZs2stbHfB7PxIUvv/9tAuWh3 I2h2HmvavsVEAXL6Eyw6WS9/f7dpzQR+KrSnfgitjJ0UUV1D0NsH+cGeygTZFGsbcuUm mAzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771756889; x=1772361689; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=t98mLj8w4amE5ycgxlNBP+sdq7EJCJ2CztJb+0KFU28=; b=aeC3DjMCWuh8/08qB9O61qnrR3Zgi7R3cHGi7NO4H6PL2+zrG1u75At4uYnns5Kn05 mbnOAlQUA6qWc1UontY6HzAWilC1GP0hl9iJAYlrPyQoqV/dC4zxXn5Ik6VO2k3LXmbi PSUUIJNELXVcbw+AyjXa7gkUk/vSF4Ct0nDjZpL/YsrIY2lwre30sFXkg96sC5pjyvHN zSKaHNS/3Q/LWh0HGmAdvqMY0lT5fPCWo+gD0GMKQudmUcCH/lWMMQ4Ig4MqTTJ2Xy3A OdiWtx27tEUkLgeN6FvxbVKRzSV8MbC9nuNYwDx53SCF9t4iL00LUOMzsZbuiugLLRQw cqcA== X-Forwarded-Encrypted: i=1; AJvYcCXdHfoXH2U7t5DOa8dFK/QcKHSwu/QwNIcAW5+/2ykU0P7Biwkk6NPzAfVgm9d0UqKfvLZh0jS9++1sDlU=@vger.kernel.org X-Gm-Message-State: AOJu0YwjSbHpjS3sauwiQ/XsytVqctX+GEH0rYuuBRd0XqPHutfJoaiB Z0KSZPtexJO0uvzO0TbyOdb38Qs1fzUKM5jaRWCqb3/ng9wZHDotXRNU X-Gm-Gg: AZuq6aKklnI+eVzfaW04z/eq4KdIaDEBQQtgyy2APnFjX/GiALokGU5yicIB4IqqpTU 8jOA8PbSQ1NthS1uPp6KByb7OcqLn6YoDqF1qXHzJF2k21xJqI7n6T8S45x3F1b3/8XR6odH1Zr a6VqcNZePsELjDfzns6RcwcRdXH1P/FtPBMWXks8+or46g6At5OUdTWKcY57Fa/LN6sHTZvQK+5 dTR62X2jg5QyaIct9Hck9ZnZfHuZXdGLixBhepmgUvLdQQ0x2+WLKGok27DwwW7AoctZApejd/z ilN9fgoWkkrr5A6xBX0apov6ScUGZjnMgVvcV0Ds2Y/QEe9vIjWZeuInw1knGYAV18mUMviJT/y wvRUAi/pMDztnoVzeSWWH/HkfVlPakQM7hR7+0XXFBxmOaQPoAi+BJMgjhQfGhT5K/wDN7qeVFz EzpZIm3Qof4NPgJRuSC7lxfW70wWsFHoJ1Hi7/P/PKVXs4yVkO1xKAAyfkTmJRfP84wDDDyLy+d rsSS0SS X-Received: by 2002:a05:600c:a00d:b0:482:df17:bbbc with SMTP id 5b1f17b1804b1-483a95e2535mr81859115e9.20.1771756888545; Sun, 22 Feb 2026 02:41:28 -0800 (PST) Received: from jernej-laptop.localnet (86-58-126-118.dynamic.telemach.net. [86.58.126.118]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483a3deb73bsm59542655e9.3.2026.02.22.02.41.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Feb 2026 02:41:28 -0800 (PST) From: Jernej =?UTF-8?B?xaBrcmFiZWM=?= To: Michael Turquette , Stephen Boyd , Chen-Yu Tsai , Samuel Holland , Alexandre Belloni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Ripard , Junhui Liu Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, Junhui Liu Subject: Re: [PATCH 0/7] rtc: sun6i: Add support for Allwinner A733 SoC Date: Sun, 22 Feb 2026 11:41:26 +0100 Message-ID: <5061953.GXAFRqVoOG@jernej-laptop> In-Reply-To: <20260121-a733-rtc-v1-0-d359437f23a7@pigmoral.tech> References: <20260121-a733-rtc-v1-0-d359437f23a7@pigmoral.tech> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Hi! Dne sreda, 21. januar 2026 ob 11:59:06 Srednjeevropski standardni =C4=8Das = je Junhui Liu napisal(a): > Add support for the Allwinner A733 RTC and its internal Clock Control > Unit (CCU). Reuse the rtc-sun6i rtc driver while introducing a new > SoC-specific RTC CCU driver to handle the hardware's evolved clock > structure. >=20 > To facilitate this addition and improve driver modularity, transition > the binding between the RTC and its internal CCU from direct > cross-subsystem function calls to the auxiliary bus. Also extract shared > IOSC and 32kHz clock logic into a standalone ccu_rtc module for reuse > across newer SoC generations. >=20 > The A733 implementation supports hardware detection of three external > crystal frequencies (19.2MHz, 24MHz and 26MHz), which is represented in > the driver via read-only mux operations. Implement logic to derive a > normalized 32kHz reference from these DCXO sources using fixed > pre-dividers. Additionally, provide several new DCXO gate clocks for > peripherals, including SerDes, HDMI, and UFS. This work looks nice, but I have some questions/comments: =2D you're missing RTC SPI clock, which is needed for RTC, at least accordi= ng to vendor 5.15 DT. Could it be that this bit set by vendor U-Boot so you missed it during testing? Manual says that it's disabled by default. =2D Vendor DT has strange RTC CCU phandles for UFS and HDMI. In first case uses RTC wakeup and in second DCXO, which doesn't make any sense. Did you do any experimentation with these clocks? It wouldn't be the first time that either code or manual contained some kind of error. Btw, switch last two patches. With current order during bisection you would get a complaint that A733 RTC CCU driver is not present. Best regards, Jernej