From: Lan Tianyu <lantianyu1986@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Question about dev_uevent_filter
Date: Tue, 25 Sep 2012 23:13:43 +0800 [thread overview]
Message-ID: <5061CA27.7060006@gmail.com> (raw)
hi Greg:
I find only devices which has bus_type or class can add uevent callback
and output the uevent information. This is because the dev_uevent_filter just return
true for these devices. But some device may not have class and bus_type.
e.g usb endpoint, if we assigned them to usb_bus_type, device core will
try to create sysfs directory link under /sys/bus/usb. But endpoint sysfs
directory's name are same for each usb devices.e.g ep_00, every usb device will
create the endpoint. So in this situation, we can't assign usb endpoint to
usb_bus_type. So even if uevent callback was added and with some information,
it still couldn't output anything. Can we add dev->type check in the
dev_uevent_filter() and return 1 if type exits?
/drivers/base/core.c
static int dev_uevent_filter(struct kset *kset, struct kobject *kobj)
{
struct kobj_type *ktype = get_ktype(kobj);
if (ktype == &device_ktype) {
struct device *dev = kobj_to_dev(kobj);
if (dev->bus)
return 1;
if (dev->class)
return 1;
}
return 0;
}
Thanks
--
Best regards
Tianyu Lan
next reply other threads:[~2012-09-25 15:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 15:13 Lan Tianyu [this message]
2012-09-25 15:20 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5061CA27.7060006@gmail.com \
--to=lantianyu1986@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome