From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from BYAPR05CU005.outbound.protection.outlook.com (mail-westusazon11010047.outbound.protection.outlook.com [52.101.85.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EBCC33EB17 for ; Thu, 19 Feb 2026 16:10:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.85.47 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771517429; cv=fail; b=F5zGrjFr9v1rjICzZjjBc+cdBZg308VcTphsoGVQEROBFwQ1qaGXUCWS9KIr6dUkOBjvQQ6y2YT4QHbjUVJlZHXj7VcftN2QZhn4jU78Er5/DbNeLsQczwc1lSsvTzaOTzeBY0nL6IhQxFUEAIZ6i1Rw3XEYwx7NoUvEYflrXew= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771517429; c=relaxed/simple; bh=bgmR+zfhWW9S9SgQrrwKNfs9x6W9JB4ReOwaXA6kODg=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=euAtvbIlTV0Hb7oSZ8q5pl8zk4KN390lR2GDQaPETlaqyEwQRDbmDcGjB8YxUKlF0GFjpNNMthBWBLMf3uzEwjcQM2lBp9ipXQKGdrneGtxJLytlqNX9QLUBK6QwZS6EJOKzB9+11Waz/XH7F9DQ52UNh1SrrJVzAfYxXOeFDyI= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=RTRrZS6M; arc=fail smtp.client-ip=52.101.85.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="RTRrZS6M" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tGiYnEmzkUNdDY9bN9H+PaXArLnNuZ/uI1HlSElfgM9F/iDwzP8H+TA7Osdd9thv21O+lIyw14eQ4i/1MNMRhAIhytsvpMIZac2h826h2BH6pB54mhxv5rgrojKQanOc6Pp2e0yLmC2tUGsz7ZvkLJ1LVcAt6Fn3uPR5QNnWK7r/So1G/mF+XXJC2hzNcxa7+kiyik2uhp3ubRPD/gLTrMAGhDfB6KFVUW+lqW8xzX2TK3TbPpmOFLWCAlX65upyXbnf+7c4zu/PhHpzg/vJk1ExAjBtKM3CCCOEMa0faLd+n09E53IeyNQknSVsoMYk0yt4NWK0sNNlG/WLBJEFIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5UVg4CPZFCvI4CMItBMnoV68qEN3yjbW/B6j0pvXwjI=; b=pX0+7ZbqUqsqo1dGX4iQVEu6zL0V2LSZ0mu/XNUINm0oMsEq/u8y95mFNMsYZDOh0Py4cqmQlqSGVF0FQ6BTcI5V8xev0ZgjUrIww7DH/0XApFiGmcUheRWw/Qwl8Pk0zoCdw2QJVoBTi3TVWgMwSzitmMBP81AX/g0p8E/aHpmjJ/0ajoP3iDZNPuH44WIsY7F1r5BffgtSYS5SrGlkU5YfYb16wEtslcMLrkPWfGUwAc9gSG0R9ioJQ1UwcjOliisWBg4EpvEaSjfo5gbQIXKUFfjvfLRSrGeMgBC6aybx2cpKaVQA6/873IsacKhRSrOmEytw9wHhEyZTSS5YoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5UVg4CPZFCvI4CMItBMnoV68qEN3yjbW/B6j0pvXwjI=; b=RTRrZS6MEEu1ypAWrPA5xMTDEc/Zx7nk9wJrnuCpCsh0/TmtSGjMzfKkWUWTmiGkbvMUY6hRQDKeQOQj6UOs6Mer0xT7Aweb1HBNsMfeiS3SGG0BXBPoXKOaPo9NppvHkL1DAzF4wOU0GDR4ssjpcbKJKJtiDZQhJX2F4zSf8Rk= Received: from DM6PR08CA0042.namprd08.prod.outlook.com (2603:10b6:5:1e0::16) by PH7PR12MB7869.namprd12.prod.outlook.com (2603:10b6:510:27e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.16; Thu, 19 Feb 2026 16:10:20 +0000 Received: from DS3PEPF0000C37C.namprd04.prod.outlook.com (2603:10b6:5:1e0:cafe::c6) by DM6PR08CA0042.outlook.office365.com (2603:10b6:5:1e0::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9632.16 via Frontend Transport; Thu, 19 Feb 2026 16:10:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by DS3PEPF0000C37C.mail.protection.outlook.com (10.167.23.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.12 via Frontend Transport; Thu, 19 Feb 2026 16:10:20 +0000 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Thu, 19 Feb 2026 10:10:15 -0600 Received: from [172.31.184.125] (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Thu, 19 Feb 2026 10:10:07 -0600 Message-ID: <5061a532-cf38-4fab-bd1d-9a51b1441730@amd.com> Date: Thu, 19 Feb 2026 21:40:06 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 04/21] sched/cache: Make LLC id continuous To: "Chen, Yu C" , Tim Chen CC: Juri Lelli , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Madadi Vineeth Reddy , "Hillf Danton" , Shrikanth Hegde , "Jianyong Wu" , Yangyu Chen , Tingyin Duan , Vern Hao , Vern Hao , Len Brown , Aubrey Li , Zhao Liu , Chen Yu , Adam Li , Aaron Lu , Tim Chen , Josh Don , Gavin Guo , Qais Yousef , Libo Chen , , Peter Zijlstra , "Gautham R . Shenoy" , Vincent Guittot , Ingo Molnar References: <60a05a3f50d14a7bf3b968f62cca87893c5c552c.1770760558.git.tim.c.chen@linux.intel.com> <79755f7d-cc68-4189-b6d8-850378e54017@amd.com> <95923e36-4117-4209-97aa-a92b60f2bd49@intel.com> <6a73ac0d-1fc9-49a7-87a2-65951ab2c844@amd.com> <8df218ecf39015830856c7b1053a0f777cc1ea42.camel@linux.intel.com> <579c9039-cd66-41c3-8a72-e73d6f836ee8@amd.com> Content-Language: en-US From: K Prateek Nayak In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS3PEPF0000C37C:EE_|PH7PR12MB7869:EE_ X-MS-Office365-Filtering-Correlation-Id: e9ac47ec-9205-48ca-0140-08de6fd16132 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|7416014|32650700017|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?aElsYjZ5cXdHQzlJQURYazc5QUxHWkc1a1dkVXZmVTdsRWJPZUJEN25jUHV5?= =?utf-8?B?NWhNYUxTcmR1OXlXZ2g3bUJXdWFWMHZ6amxLUVltM1lNUnFaRmEyNmxjc3p1?= =?utf-8?B?akNkSVZxMk9BVHJwMDY5S3NqbG5XalMzRDEyc01ldGpSNlJSL0ZjbVByN3BB?= =?utf-8?B?TUtNaEV2UUdaYlRwNUdNdmRQNFdhdDkrT05UbEhwSTh6SW10b0VIM1lxam90?= =?utf-8?B?cGMzZzNuV0ZNRnZ4Zk1FcmpPU1lGdHBVb1pBZHp4SnZCN0d5ZW8xVjhxaHo0?= =?utf-8?B?Z2tOUzNORWQ4aUxLckhGZGlVTmRsV0hhRVBlOW90dk5DbktxeVZkUmorQlZJ?= =?utf-8?B?WFkxbUZBQ2FzNUJTc2NaQlFDWDQ2MTZoSHZEMElmYWhFMUZkd01uTFJOMWNF?= =?utf-8?B?a1FZbVpmbGg0RFBQdjA1WGdNWXZnMFM4cjBNeFpMSjFaYzRuL0hNclQ3ZVdC?= =?utf-8?B?QytJK2RhQ1pRMzNjdE5reWNZYit4cGpDZDdxbzZudUR1c1plRzVmMUJYckV4?= =?utf-8?B?UExGSWNEb2VCTzZNUzhmZ1NTdGNJSGhSM1lJZlN4WmwvSDRtUlg1cDE4TXp3?= =?utf-8?B?cnpwUUpra0JDRldVaE1odHhqUnpCRWgvT2lpcVJGdnQ0YnZLckR4dExPdzF5?= =?utf-8?B?MEFNYUpRT08zSVlXQjJocG92ZFZlNTNYUVRXSytxaW5Scks0RSt0YTJrdm5v?= =?utf-8?B?R20rNGJ5VVNiS0lFK3E1S3dtd24vdkpMQ09aaFF1RXZmQUlhMDFOcG5qTkJI?= =?utf-8?B?OVJWYVVMTHR1U0NsazBIdEMyRDMrMDMzcjlzZ2d1dDVvUEQ4SmplRmJkdmJj?= =?utf-8?B?a1BYYS9iYmtndkVKNTgyb3lnTENGb0JHY1JMSzdSa3FmbnBPVFZTZWZYRHNC?= =?utf-8?B?TTVQb2NHYkZUeWxZQStERVF4d1BVRXgwYUY4OVcxT3Q0VW5vZk1VVm95TTl5?= =?utf-8?B?SFNUMk4wTy96b01zdTB2OHp0SXcyaVZselBlQVl0dGg5RjBwdGRORzQxNXpp?= =?utf-8?B?SzkwMGlaTTdsZzRJRGdrc2RvMnI4M1dKSG0xT0VpZkVqYzlGRGlZSm91SUJH?= =?utf-8?B?Z05NaVUxd2ZoSWVqQmNmdGxXUGorMVVJdS81LzZ3dVNkYXBLMXJ5V29QRHJ1?= =?utf-8?B?SVZyRUwwTWNWVHJxVDVMZXJqUTkrKzVJNXRkK3JzVmd2WDdmRnZUU0hZbnpZ?= =?utf-8?B?SHBCOFZ5UGxRanE1SUdKQkIyYVU5WkVoa1JmMmZsT2R0ek4zay93UkhCZ3BX?= =?utf-8?B?SjVjUCtacjgxSjlyWWQrNFZCZTZWV0Y0bWx0Uk5TZGRUZnIyenZhalRVd1dI?= =?utf-8?B?QlRPbzNNT1VRbmQyNjYweStOZyt3RGxQWkRzdkdmNlNVenk4endwQ1FpVWcr?= =?utf-8?B?UmxTcUMzOG9haW90LytOU0Z0SGJqWmRNWmF1aEV0dUpwcGtYTE9kZWJ1K0dk?= =?utf-8?B?S2hXalZqZzFzUzhFcFozdVlQWHJmeFlDV3FFSEZkZ0JTZEJoMXBzNTVQU1pC?= =?utf-8?B?Um5oWGtsbW5xR1F0TmZENC9FWDdqSUxxOUtuYmk1TmMxKzFnQjQ4LzdNNmpL?= =?utf-8?B?UnhRNHZxdExxcTR4OFpyWTNxMlBNa1I4YklUM28wQ2tMYVJ3aHg0dTNVMmxV?= =?utf-8?B?UlRkdFdhSEtaVHpsL3p1VVNFMDkyNmhZUytIUkhqZXZ6NUtOUUNZN21KSlB3?= =?utf-8?B?YWU1clFLYmtOMExWU2ZFSFJXejVkZEVtVHVmWlRvUDRnajc2WTQycmROd0pP?= =?utf-8?B?MGRBci9YMTdtOHV3Q2NHQUE1UWRVMUkrZ0daZEZVTHlxaVdQM0dReDNnampX?= =?utf-8?B?TXJBRUVvelU2Z1VTbGJvU2Zva0tqcTVTVjVuTGtmRy94emRMQmNSQm5Cc2hx?= =?utf-8?B?MkRhdGRqSmJlS1RUYldjYXJodm02NkpSK0Q4d3dFb1FyU2pBbXdZcUlVVGh1?= =?utf-8?B?VDM2djY2U1dWTlMrdEFENWpYRmY5VHZEMCtRQXRRM2JMWEQzSzlkZzJDUmNE?= =?utf-8?B?U0VnM1lCNHphWGVObVB3VDFWeGxqNHQxbDBFdjBTNkxOVW9kY2x0Z0JFeHBs?= =?utf-8?B?emptd04rdnFhNWpRUGZlVzdyYmpaMWoxUlcwdVBPVm9ucUp5ZkZPelJ4VVF6?= =?utf-8?B?UTRCazlNNTlaU0dVRXpSQkszUmJFYVNCd2VtdTNPWDVlK1Ztbm9hNllOQTc2?= =?utf-8?B?U1p6NEFSS1VEYWluMmZma1NCbkZaR0VZMHYxb1FCY05mcVBQWFBERUJSZUxB?= =?utf-8?B?N2ZHVWlLVk9hMWJ6UHRTVUdGTkNRPT0=?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(376014)(7416014)(32650700017)(36860700013)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: h/xKblAGk8PRZPv/BbGaGsg7MS1ebaXenvRYeabAhmJye6ojhoNnD4wmoQtT5Atdhz+SMolj/AFLBgcuW2AieuVH4Ckfe1fYf/sdMCr4mcYoIOqMH/SwGsUHRoteKQZ1JirMLF1TvFcB1tZCBIgMdvEkJF3nuHM798HU8c4Ysp5GxCc/rbp2LOzOrBHUf+BY3smF+i4X3UpvAD/fA1KhGMw0iCmQiUOEUvo4vyLMq/bGD+FA6MTfCaPxWXbEQQIWLqYN70iCxPRiqqhHXruOYdlQJqf1RcLRYEmMAPrXmCW6I5lJoSThT2i+uuat2GYpbgVkD3p1qpz6r2QfdHestMDX+IHwysOF7ZqfARoCA1Y+bpqCGfMV/0+xUaiMNyz5m7ebc356JlU/QbWIO993WZA43SYkO4XQvYwDhbxAjvnlok/fLqiBipc72tsGQUDJ X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2026 16:10:20.2007 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e9ac47ec-9205-48ca-0140-08de6fd16132 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS3PEPF0000C37C.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7869 Hello Chenyu, On 2/19/2026 4:55 PM, Chen, Yu C wrote: >> +static void __sched_domains_free_llc_id(int cpu) >> +{ >> +    int i, lid; >> + >> +    lockdep_assert_held(&sched_domains_mutex); >> + >> +    lid = per_cpu(sd_llc_id, cpu); >> +    if (lid == -1) >> +        return; >> + >> +    per_cpu(sd_llc_id, cpu) = -1; >> + >> +    for_each_online_cpu(i) { > > One minor question: should we only iterate through > cpu_coregroup_mask(cpu) to check if any sibling CPU > within this LLC owns the llc_id? If there are no online > CPUs within this LLC, I assume we should release this > llc_id. That should work too! I'm assuming the arch/ side unlink happens before this in which case we can simply check cpumask_empty(cpu_coregroup_mask(cpu)). > > thanks, > Chenyu > >> +        /* An online CPU owns the llc_id. */ >> +        if (per_cpu(sd_llc_id, i) == lid) >> +            return; >> +    } >> + >> +    cpumask_clear_cpu(lid, sched_domains_llc_id_allocmask); > -- Thanks and Regards, Prateek