From: Dave Hansen <dave.hansen@intel.com>
To: Aaron Lu <aaron.lu@intel.com>
Cc: Jarkko Sakkinen <jarkko@kernel.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, linux-sgx@vger.kernel.org,
linux-kernel@vger.kernel.org, Zhimin Luo <zhimin.luo@intel.com>
Subject: Re: [PATCH] x86/sgx: Fix deadloop in __sgx_alloc_epc_page()
Date: Fri, 30 Aug 2024 07:03:33 -0700 [thread overview]
Message-ID: <50688c67-59a3-46e4-a2b5-10c1e93d4b3c@intel.com> (raw)
In-Reply-To: <ZtFgem6_2j05S0MJ@ziqianlu-kbl>
On 8/29/24 23:02, Aaron Lu wrote:
>> Also, I do think we should probably add some kind of sanity warning to
>> the SGX code in another patch. If a node on an SGX system has CPUs and
>> memory, it's very likely it will also have some EPC. It can be
>> something soft like a pr_info(), but I think it would be nice to have.
> I think there are systems with valid reason to not setup an EPC section
> per node, e.g. a 8 sockets system with SNC=2, there would be a total of
> 16 nodes and it's not possible to have one EPC section per node because
> the upper limit of EPC sections is 8. I'm not sure a warning is
> appropriate here, what do you think?
While possible, those systems are pretty rare. I don't think a
softly-worded pr_info() will scare anyone too much.
next prev parent reply other threads:[~2024-08-30 14:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 2:38 Aaron Lu
2024-08-29 7:47 ` Huang, Kai
2024-08-29 7:56 ` Huang, Kai
2024-08-29 13:22 ` Aaron Lu
2024-08-29 15:17 ` Dave Hansen
2024-08-30 6:02 ` Aaron Lu
2024-08-30 14:03 ` Dave Hansen [this message]
2024-09-02 7:57 ` Aaron Lu
2024-08-29 16:44 ` Jarkko Sakkinen
2024-08-30 6:14 ` Aaron Lu
2024-09-03 16:05 ` Jarkko Sakkinen
2024-09-04 1:39 ` Aaron Lu
2024-09-04 14:17 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50688c67-59a3-46e4-a2b5-10c1e93d4b3c@intel.com \
--to=dave.hansen@intel.com \
--cc=aaron.lu@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=jarkko@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=x86@kernel.org \
--cc=zhimin.luo@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®