From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752792Ab2JBLy0 (ORCPT ); Tue, 2 Oct 2012 07:54:26 -0400 Received: from nat28.tlf.novell.com ([130.57.49.28]:48264 "EHLO nat28.tlf.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751593Ab2JBLyY convert rfc822-to-8bit (ORCPT ); Tue, 2 Oct 2012 07:54:24 -0400 Message-Id: <506AF20C020000780009F0B5@nat28.tlf.novell.com> X-Mailer: Novell GroupWise Internet Agent 12.0.0 Date: Tue, 02 Oct 2012 12:54:20 +0100 From: "Jan Beulich" To: "Stefano Stabellini" Cc: "Stephen Rothwell" , "Greg Kroah-Hartman" , "Konrad Rzeszutek Wilk" , "linux-kernel@vger.kernel.org" , "linux-next@vger.kernel.org" Subject: Re: linux-next: manual merge of the xen-two tree with Linus' tree References: <20121002141949.f6e61437bdce0d56d9d4321e@canb.auug.org.au> <506AEE0C020000780009F0A1@nat28.tlf.novell.com> In-Reply-To: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>> On 02.10.12 at 13:45, Stefano Stabellini wrote: >> > Considering that dbgp doesn't seem to be very useful without PCI at the >> > moment, could we just turn it into: >> > >> > dom0-$(CONFIG_PCI) += dbgp.o >> > >> > ? >> >> Better not - the code is specifically not PCI-only. And I can't see >> how it would be harmful to be compiled on e.g. ARM (so the >> merge perhaps really should use XEN_DOM0 alone, without >> X86. If anything (and that may indeed be a minor oversight of >> the original patch) one might want it to depend on USB_SUPPORT, >> as without that no in-tree debug port capable driver would be >> able to load (and hence interfere with Xen's use of the debug >> port). However, as long as it builds fine with USB_SUPPORT >> undefined (which I believe it does), having it in the shape it >> is allows for out-of-tree drivers as well (as long as they make >> use of the designated interface). > > OK for PCI. > Regarding USB_SUPPORT, considering that gbgp.c calls hcd_to_bus, I think > it would make sense to make it depend on it. As said - I'd prefer to do that only if indeed needed to get things to build without that option. Since include/usb/* doesn't reference CONFIG_USB_SUPPORT, I'm in favor of supporting at least those eventual out-of-tree drivers that do use the pre-existing data structures (and others shouldn't be calling pre-existing APIs anyway). But I wouldn't NAK a patch doing what you suggest either. Jan