mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
	David Herrmann <dh.herrmann@gmail.com>
Cc: Markus Trippelsdorf <markus@trippelsdorf.de>,
	Jiri Kosina <jkosina@suse.cz>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"open list:HID CORE LAYER" <linux-input@vger.kernel.org>
Subject: Re: [GIT] HID for 3.12 merge window
Date: Fri, 06 Sep 2013 17:58:41 -0700	[thread overview]
Message-ID: <506b9d43-f734-40f9-b137-0749a496fd6d@email.android.com> (raw)
In-Reply-To: <CA+55aFzg-dv-N7UjXx2pxUJ+QQOOy0qtp_e94PDSM=tVd=LgUw@mail.gmail.com>

Linus Torvalds <torvalds@linux-foundation.org> wrote:
>On Fri, Sep 6, 2013 at 2:50 PM, David Herrmann <dh.herrmann@gmail.com>
>wrote:
>> Hi
>>
>> On Fri, Sep 6, 2013 at 10:20 PM, Markus Trippelsdorf
>>>
>>>  commit 61e00655e9cb82e034eb72b95a51072e718d14a7
>>>  Author: David Herrmann <dh.herrmann@gmail.com>
>>>  Date:   Mon Aug 26 19:14:46 2013 +0200
>>>
>>>      Input: introduce BTN/ABS bits for drums and guitars
>>>
>>> The commit above breaks my Logitech mouse. The mouse cursor just
>sits in
>>> the middle of the screen and doesn't react to movements. dmesg is
>>> normal, but Xorg.0.log says:
>>
>> Ok, the issue is the kernel assumes ABS_MAX to be a power-of-2 minus
>1
>> (used as mask). That wasn't really obvious to me. Attached is a patch
>> which should fix that. Could you apply it on top of linus/master and
>> give it a try?
>
>Gah. I just wasted too much time bisecting down my logitech wireless
>keyboard not working to within a few commits of this, and decided to
>just try your patch.
>
>And yes, it makes my keyboard work.
>
>Dmitry, should I just apply the patch, or should we revert and use
>other bits? Please, this needs to be resolved, I stopped merging when
>I noticed this problem..

The patch still had problems so I'd revert it and wii bits and try again later.


Thanks.

-- 
Dmitry

  reply	other threads:[~2013-09-07  0:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-06 12:00 Jiri Kosina
2013-09-06 20:20 ` Markus Trippelsdorf
2013-09-06 21:50   ` David Herrmann
2013-09-06 21:59     ` Markus Trippelsdorf
2013-09-06 22:51       ` David Herrmann
2013-09-06 23:10         ` Dmitry Torokhov
2013-09-06 23:57     ` Linus Torvalds
2013-09-07  0:58       ` Dmitry Torokhov [this message]
2013-09-07  1:00         ` Linus Torvalds
2013-09-07  3:22           ` Dmitry Torokhov
2013-09-07  7:31             ` David Herrmann
2013-09-07  7:32               ` David Herrmann
2013-09-07  8:24               ` Benjamin Tissoires
2013-09-07  8:57                 ` David Herrmann
     [not found]                   ` <522AEFE9.30402@gmail.com>
2013-09-07  9:29                     ` David Herrmann
2013-09-07 17:12                       ` Dmitry Torokhov
2013-09-07 16:52               ` Linus Torvalds
2013-09-07 17:31                 ` David Herrmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=506b9d43-f734-40f9-b137-0749a496fd6d@email.android.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=dh.herrmann@gmail.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markus@trippelsdorf.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®