From: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 0/3] net: stmmac: Fix usage of maximum queue number macros
Date: Tue, 28 Jan 2025 11:41:20 +0900 [thread overview]
Message-ID: <506cfa39-924e-479b-be2d-b032664958a9@socionext.com> (raw)
In-Reply-To: <Z5dXJ1EIUx8DAh6J@shell.armlinux.org.uk>
Hi Russell,
On 2025/01/27 18:51, Russell King (Oracle) wrote:
> On Mon, Jan 27, 2025 at 06:24:47PM +0900, Kunihiko Hayashi wrote:
>> The maximum number of Rx and Tx queues is defined by MTL_MAX_RX_QUEUES
> and
>> MTL_MAX_TX_QUEUES respectively.
>>
>> There are some places where Rx and Tx are used in reverse. Currently
> these
>> two values as the same and there is no impact, but need to fix the usage
>> to keep consistency.
>
> I disagree that this should be targetting the net tree - I think it
> should be the net-next tree. Nothing is currently broken, this isn't
> fixing a regression, there is no urgent need to get it into mainline.
> It is merely a cleanup because both macros have the same value:
>
> include/linux/stmmac.h:#define MTL_MAX_RX_QUEUES 8
> include/linux/stmmac.h:#define MTL_MAX_TX_QUEUES 8
I was a bit confused about how to choose net and net-next in this case,
but I understand what you are saying.
As I wrote:
>> Currently these two values as the same and there is no impact
this case isn't about fixing what is broken and also not required fixes
for the stable kernel, so I should post this series to net-next without
Fixes: tag.
> Please re-send for net-next after the merge window and net-next has
> re-opened.
I see. I'll take care and repost.
Thank you,
---
Best Regards
Kunihiko Hayashi
prev parent reply other threads:[~2025-01-28 2:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-27 9:24 Kunihiko Hayashi
2025-01-27 9:24 ` [PATCH net 1/3] net: stmmac: Fix use of queue max macros for Rx interrupt name Kunihiko Hayashi
2025-01-27 9:24 ` [PATCH net 2/3] net: stmmac: Fix use of queue max macros for Rx coalesce Kunihiko Hayashi
2025-01-27 9:24 ` [PATCH net 3/3] net: stmmac: Fix use of queue max macros for irq statistics Kunihiko Hayashi
2025-01-27 9:51 ` [PATCH net 0/3] net: stmmac: Fix usage of maximum queue number macros Russell King (Oracle)
2025-01-27 11:11 ` Huacai Chen
2025-01-27 13:21 ` Andrew Lunn
2025-01-27 13:47 ` Huacai Chen
2025-01-27 21:03 ` Jakub Kicinski
2025-01-28 2:42 ` Kunihiko Hayashi
2025-01-28 2:41 ` Kunihiko Hayashi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506cfa39-924e-479b-be2d-b032664958a9@socionext.com \
--to=hayashi.kunihiko@socionext.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®