From: Laxman Dewangan <ldewangan@nvidia.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "lrg@ti.com" <lrg@ti.com>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
Venu Byravarasu <vbyravarasu@nvidia.com>,
"axel.lin@gmail.com" <axel.lin@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: TPS51632: Add tps51632 regulator driver
Date: Tue, 9 Oct 2012 11:37:53 +0530 [thread overview]
Message-ID: <5073BF39.5020008@nvidia.com> (raw)
In-Reply-To: <20121009061436.GH8237@opensource.wolfsonmicro.com>
On Tuesday 09 October 2012 11:44 AM, Mark Brown wrote:
> On Sat, Oct 06, 2012 at 08:47:46PM +0530, Laxman Dewangan wrote:
>
> Actually...
>
>> + if (pdata->dvfs_step_20mV)
>> + control |= TPS51632_DVFS_STEP_20;
>> + tps->desc.uV_step = TPS51632_VOLATGE_STEP_10mV;
> Shouldn't the dvfs_step_20mV setting affect the uV_step size?
The dvfs_step_20mV will only effect for the control through DVFS (PWM).
The voltage control an voltage base register will till use the 10mV steps.
next prev parent reply other threads:[~2012-10-09 6:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-06 15:17 [PATCH 0/5] regulator: tps65090: fix regulator registration and add external control support Laxman Dewangan
2012-10-06 15:17 ` [PATCH] regulator: TPS51632: Add tps51632 regulator driver Laxman Dewangan
2012-10-09 6:14 ` Mark Brown
2012-10-09 6:07 ` Laxman Dewangan [this message]
2012-10-06 15:17 ` [PATCH 1/5] regulator: tps65090: rename driver name and regulator name Laxman Dewangan
2012-10-08 5:53 ` Venu Byravarasu
2012-10-08 6:00 ` Laxman Dewangan
2012-10-06 15:17 ` [PATCH 2/5] regulator; tps65090: Register all regulators in single probe call Laxman Dewangan
2012-10-09 6:22 ` Mark Brown
2012-10-09 6:16 ` Laxman Dewangan
2012-10-06 15:17 ` [PATCH 3/5] regulator: tps65090: Add support for LDO regulators Laxman Dewangan
2012-10-06 15:17 ` [PATCH 4/5] regulator: tps65090: Add voltage out level in platform data Laxman Dewangan
2012-10-09 6:26 ` Mark Brown
2012-10-06 15:17 ` [PATCH 5/5] regulator: tps65090: add external control support for DCDC Laxman Dewangan
2012-10-08 5:45 ` Venu Byravarasu
2012-10-08 5:58 ` Laxman Dewangan
2012-10-09 6:28 ` Mark Brown
2012-10-09 6:21 ` Laxman Dewangan
2012-10-09 7:04 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5073BF39.5020008@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sameo@linux.intel.com \
--cc=vbyravarasu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®