From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f170.google.com (mail-il1-f170.google.com [209.85.166.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B9A91D86ED for ; Wed, 15 Jan 2025 21:14:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736975670; cv=none; b=hNfTCvv6Q8W8P3pHh+sdaFLROA4fLyHUp+NjpkbjS35VolbDQCWt1CyoLS0/XzP2alJRKHASYEtiRdWFR0utS5Ffq199KQC/6fd+ZCet3nj5Za2aXmgcmo3/3z5H+Eo9WjbJ906NCUTUXh9/vAgylTg1A21YpTjwvbwPp/BS89U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736975670; c=relaxed/simple; bh=vrrxo8HiiPKY/ALbdGOG+3UGWwNQlyN3pm2x2fkSNmY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=a7nzYg5qA/QW+6SMJS1Zn+qzsRe8Llcg6bH4lA/YSOHP5VLk5Y/fZ0r0V8Y+VLVcJd2U8ny5qlTNpY3feNowQ7eWmMYy0mnQZQYDWNF+llLVwjymy0kO1YeU1KtM4Z0AALdHzufkNEIqQm3FtjyrxGtI1dGbse3Rr27pyU3xWyk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=VRYOmMLc; arc=none smtp.client-ip=209.85.166.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="VRYOmMLc" Received: by mail-il1-f170.google.com with SMTP id e9e14a558f8ab-3a8160382d4so757585ab.0 for ; Wed, 15 Jan 2025 13:14:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1736975668; x=1737580468; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FzfMgKLvrqiiputvynaSoARnyM5qxWu52sQacdJxD4k=; b=VRYOmMLcNUa0ymhWEbYMre+TONH/gWFQEb2nfuVThSeD2Bybjsz7ffT3AGoqxDP5WF 7qJBgUmfCGbHG/d3csHAB7YfqOYD5GxA+QAQQbXDIUvVdY97qsmAggHBzHInpLDMRb5v 3JRtbIm0XqzQ+CUJ/mOv6SKT+18ZqNK2v6pmc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736975668; x=1737580468; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FzfMgKLvrqiiputvynaSoARnyM5qxWu52sQacdJxD4k=; b=p9AkKqI5OTZnlPq19spJ2LbtDL19b0/z8d3sneQwrb6xLBN0D2q5Vq5kKFP0cgoKal QY8vBrFaGvQdfMH7JfJXf3bliMSNW0qWq5O/6S5GpIqOcrdMs4dy2go4ChC1FN2B+hpj NBQls3McgDt+Hin3OCxNnujU6xzAaiantEUhEGeHSsw/VCYZJbt4i7oQm45bHQuZleSg 7nFffJ/iSDDq/wRX0F+MeCAze4kiAdKc0r9PfzA2pBQo/Gi2myp6UU+TIm5XdHSDI65u R/mHfkRqiGykLoJsp2OxUYvpG6rkVvGE2ATbInCPfpir+d60BwJbGoTiRcxYvZx5/okc UZJA== X-Forwarded-Encrypted: i=1; AJvYcCVzeZMADwmVkGnKICHAy8zPUQM/pj7PHFIBjiIS8xZba1xqWLG+DazyVezm5xbHAMqhOQmwiMmtLWeXsIk=@vger.kernel.org X-Gm-Message-State: AOJu0Yy7rW8Eiz6X2oRwGx7hVIVAr15ak6ik00Y5zBoRSxpKsbyrqBt1 phZ8/aDm0FvPlb0Whnd71DFYhXblFhe4VvCDm0wzzBMRuOrAXotwlXdZlerhl9g= X-Gm-Gg: ASbGncshZgkGjkkZO3hoKMHibXSlMhKPeDV2FN7WfXUIh+6UQRTfQWxFVM75UkmFk7v 2PSPP8pOxDXHYxGyzmPeOdLt2V+63218o8fSIw0ENCc3jrpyD6zFQJFPQbYUiNrGyXnOkjG5V2J ob6+JlqMnshFLPEuyF5UY4mlX2e14bJIcmbwy6WJERupqeG7PAtFh8hTgsam76KWaiIdLmL4WVh xgH73g3uLlbqfw+iaiZZQmbDiZr/oerK0K3isXpJjojmleEAz2oxI280MQcAmWpPic= X-Google-Smtp-Source: AGHT+IHaU3+g2ZDtBaHUU2KctM8WKXekirKK/9gJhB2Y/OuE7O3nHoFPshcXSrfr48VJ8r1RlYtBqA== X-Received: by 2002:a05:6e02:1388:b0:3ce:7b61:588 with SMTP id e9e14a558f8ab-3ce7b6105admr65488075ab.14.1736975668288; Wed, 15 Jan 2025 13:14:28 -0800 (PST) Received: from [192.168.1.14] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4ea1b7459e9sm4344948173.118.2025.01.15.13.14.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Jan 2025 13:14:27 -0800 (PST) Message-ID: <507650bd-f1c5-47b2-8d61-31d50e4a85e2@linuxfoundation.org> Date: Wed, 15 Jan 2025 14:14:27 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] usbip: Fix seqnum sign extension issue in vhci_tx_urb To: Xiong Nandi , Valentina Manea , Shuah Khan , Hongren Zheng , Greg Kroah-Hartman Cc: "open list:USB OVER IP DRIVER" , open list , Shuah Khan References: <20241231161539.20192-1-xndchn@gmail.com> <20241231161539.20192-2-xndchn@gmail.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20241231161539.20192-2-xndchn@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/31/24 09:15, Xiong Nandi wrote: > The atomic_inc_return function returns an int, while priv->seqnum is an > unsigned long. So we must cast the result to u32 to prevent potential > sign extension and size mismatch issues. > > Signed-off-by: Xiong Nandi > --- > drivers/usb/usbip/vhci_hcd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c > index b03e5021c25b..f3f260e01791 100644 > --- a/drivers/usb/usbip/vhci_hcd.c > +++ b/drivers/usb/usbip/vhci_hcd.c > @@ -675,7 +675,7 @@ static void vhci_tx_urb(struct urb *urb, struct vhci_device *vdev) > > spin_lock_irqsave(&vdev->priv_lock, flags); > > - priv->seqnum = atomic_inc_return(&vhci_hcd->seqnum); > + priv->seqnum = (u32)atomic_inc_return(&vhci_hcd->seqnum); > if (priv->seqnum == 0xffff) > dev_info(&urb->dev->dev, "seqnum max\n"); > Acked-by: Shuah Khan thanks, -- Shuah