From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D572210F2 for ; Tue, 7 Apr 2026 05:48:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775540908; cv=none; b=keaExhyN7t0SBLmPtwp0nEVjJg0pL0mgtEqMmPOcEOuH9mhHfv80iPiCGI3s7PYVchUbxR7RsctES5JZ8k3IneH06d4FP8FoZMWPNFnQP85E3MGtkOtC+SLrWm47R4q61twXYpSrNZonl7rTLx9NUgneNzP90V9dKoWkFPfIBb8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775540908; c=relaxed/simple; bh=sjhu8s/9BEyLmfTn3Gefm+TsPuDKvZMrkElzt+2EY1U=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=c1QoLR6u5cRvYDAh5MgsYnk1OJQ9pplYMG0X683Rb45DgsY5I1kLI4AqLmEju8f3dPyMg88mRSEYfjyL9AAec2MoMG6ffPulfgEsr8bYADATUy8A+z8mbTp45uyr659yRAjsaQDj/y4M6E9p7lE8qdjNOLo52ZZODssGz09Mr4c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BV2DlM7V; arc=none smtp.client-ip=209.85.167.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BV2DlM7V" Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-5a2c981e5dcso4789061e87.3 for ; Mon, 06 Apr 2026 22:48:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775540905; x=1776145705; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=sYD6o8pTb5SmWUUWjzRiT8q6m8i/9lJd0DY3W44VJyg=; b=BV2DlM7VOmRsP4lK5UaZVK8khaLCrLVo9rFMvfeDYnna3OU+LaHwhoZM+xWHbYfKY3 W4xVfnL+esCLlpMV035tMtAERyFzd6A/6DgDKRPTpP+407hCmtpKsDaoNV4SZfau8AU0 CYWSP5OtEGqkIc8hAX1nPYdN91kJWT/lOFvbl9Ca/t/gPVE8lG4gMFE3h77InP3YD0Oe B8TNo+CbN3beA7sqJluYOy8x/OOYnEYemt18vvuWwRhYFT2+K3xRGEYJRQmRHRwQGBON Tt3S8tCBIT4mLUbfFspnxAhqtmtM1tO55pRsCl1SuQ5ykVyBsAZ+zgK07e7XofclhAI+ w5RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775540905; x=1776145705; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sYD6o8pTb5SmWUUWjzRiT8q6m8i/9lJd0DY3W44VJyg=; b=V8EGUcPOkFfvYcxcWKzFNVr/KMM8FRL/4bR2Y3DMwR8W/GArnpmN5ZFNW718Xv7iwV DeGVdeuaA8az0fc+POnI3g/dgXPIFEALUICwjxzzZ1kPkttQkSzzeCei3kMbHnrzUKz1 pjMVzL7gNE1cyrsxiVlLQ8Q3dxDhUQqD+rmRwxhd4057j/FsR/48KOePO4GVkSV8jsm4 txk8ZwcXeHcffX/D4wJ+5QlQqyP1ZflBgpKSPOg2FZIA3juVzdD7NAcJc0uFLpdeypsb eHTsnqudHIgI+m6SJvPt+iz9pcz0IwvQAf/doG92l5h5n+bhYBqzpyip3ucUDgElSqrZ oE8w== X-Forwarded-Encrypted: i=1; AJvYcCXkOnQABWIk+HMKcDE2FGv6wwsJEMnuqBE0ICZuIgijhW9IUIQlUwYqEJK4PmajTf+wwEcMp0o0pp/fFfc=@vger.kernel.org X-Gm-Message-State: AOJu0Ywwr/JBP5l9Isd8k15CkLSZdhFac7TDwyR9LvtZsXdhFTw9Mcjv 5vk98wvOFd/8NX5CSBJ4gGacPJLy2n9H2O1YVs65Zl/JmRJmwdlBmXkX X-Gm-Gg: AeBDiet1wlm0b56hdrSlBvXqTcnp2oGilRGrGrHZzDHpx1LsJ45K4jy+TSYXJ4JcoEk JPYejMZhn3v4EVQ1VuXXvn2yeHN8Gw8jrr1md16JhuNUGckh06gBJ3XecaWQ7B6p/9TwWTy66Xd 0eU9HPk6b20DumiiSzBmLOEMtKNU29XszV01BYsGWrVSbNcz6P0iyMAkf3qUhBkVnXmBiQb8Avd UDZ0g5k1nIFF3lKhN22Gj1yZCY8DBWbgoqyug032YN66lPlreHlNGaJS7d2D3N78Yi1Rz+bA0D6 NwRrqHNUMe7jNgMfO3RAojc1sHd029QWziK7+q0+lcps7gzFupCFKcN22jgnNn+FamJ1/i4P6HC fkBB4ot8NIBNkGwnIZVClyqVoztCwoD8j5dZETBs3IH9siq9AOc0Ft1ZCfKw8zPeM5yn7tk7zaG v/5czpaEMSDivNyiS1xhVXnxqY8+8vRCVa6ZxDtvh2i8MyMuNhOFjqCuMI6XMop9Qa2T4OANfdq z20zZA8 X-Received: by 2002:a05:6512:3c85:b0:5a2:a70a:a87 with SMTP id 2adb3069b0e04-5a33755cc62mr5629460e87.4.1775540904296; Mon, 06 Apr 2026 22:48:24 -0700 (PDT) Received: from ?IPV6:2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703? ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a2c6ccc9fasm3756778e87.63.2026.04.06.22.48.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Apr 2026 22:48:23 -0700 (PDT) Message-ID: <50777d1c-f133-4402-bf89-055719651004@gmail.com> Date: Tue, 7 Apr 2026 08:48:23 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] power: supply: bd71828: add input current limit property From: Matti Vaittinen To: Andreas Kemnade , Sebastian Reichel Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260401-bd-inp-limit-v1-1-689eb22531e2@kemnade.info> <16340915-f63f-41f7-b68f-6208120d9c09@gmail.com> Content-Language: en-US, en-AU, en-GB, en-BW In-Reply-To: <16340915-f63f-41f7-b68f-6208120d9c09@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 07/04/2026 08:34, Matti Vaittinen wrote: > On 02/04/2026 00:17, Andreas Kemnade wrote: // snip >> +    .ilim_stat = BD71828_REG_ILIM_STAT, >>       .btemp_vth = BD71828_REG_VM_BTMP_U, >>       .chg_state = BD71828_REG_CHG_STATE, >>       .bat_temp = BD71828_REG_BAT_TEMP, >> +    .dcin_set = BD71828_REG_DCIN_SET, > > Hi Andreas / Sebastian, > > Sorry for belated review (although, I don't think this did float on the > list quite THAT long...) > > I believe this is the ILIM_STAT register in the data sheet, at address > 0x6d, right? (The bit field is named as: LIM_DCIN_STAT[5:0]). If so, > then I have a follow-up question in the setter... // snip >> +        return regmap_update_bits(pwr->regmap, pwr->regs->dcin_set, >> +                      BD7182x_MASK_ILIM, >> +                      val->intval / 50000 - 1); > > The "burning question" I have is - how well this has been verified? I > ask because the data-sheet version which I read (rev 0p17, DS2 draft) > marks this register as a read-only. I know my data-sheet, targeting the > design-sample 2 of bd71828 (not bd71879) is ancient. It may be this is > an error in the data-sheet but I had to ask anyways... Please, ignore this bit. I somehow misread the patch. It is the DCIN_SET which is used here, not the ILIM_STAT. Logic seems correct! I would still prefer the linear-ranges, especially if other variants support this. But the logic seems correct. Sorry for the noise. Yours, -- Matti --- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~