From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B24434252D for ; Sat, 21 Feb 2026 09:40:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771666811; cv=none; b=NNtwacw24LM7g6yPSHDxJWkYmx3Y6oCHif2m8P0wlhnDeUMmGToVKxRybzOswAfL+YySKYisLUD9SAi2386knPOJPy70Kfh/J1BDE6IZW5v5odFlA5rtGj1TcZuI2g6JDwx0lc3TorrvvScqw67kNqwpwJtpEjlGeD7xEJtu/XU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771666811; c=relaxed/simple; bh=X2dvvtP0QHY/bsWx4Eesgw3WQJgKi927oam26nArPGM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=uWv4qG63wLrb/MuuQQnF4WUmvMh4T+BKkML8hbAG6QpJfMcGh1zBHmZoh3PTgHntQgD3SvttoK/03FBWOghibTWLPBAjkgUvhOQ2O+GDWwTs4C/sFrw0EQKsfjBFvDF+9Iu4VDPNy9Lp1pi9I1UcwajxSuQE9kSfd6ZRpnqB9E8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HDGuPmfe; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HDGuPmfe" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-43767807da6so2055323f8f.2 for ; Sat, 21 Feb 2026 01:40:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771666808; x=1772271608; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=X2dvvtP0QHY/bsWx4Eesgw3WQJgKi927oam26nArPGM=; b=HDGuPmfeYhvkJUzNhEk+Klv402zDdxmL5fbq8Gt/bB17hEtNwVr/XPKmWJBrkLz9T1 Vu0jpUEhxmlwj7L6hCOX0sASc+BSjE/CBWbvYPhAJSD3c1nwjngwW0D2su7P+br3CUy9 b+Dr77hqsrSGULCESkwoy3+zrSts/2quNDT60okrJ+DT/mBSJRjRHu77xzRTwAqN9mGw HUeaa7Sn+rzM2x+UUEbCuDzzlhLR7E7GKWgVZTpR2mSGoRoD8OfqehcRnE6ZpfGrHlNY V39zVQjGltD3lAKfKo4Pllc8/PdTlEG4MsPpNBR74FAlklgLReTL9fmbzUsKerCW6Q6A tuTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771666808; x=1772271608; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=X2dvvtP0QHY/bsWx4Eesgw3WQJgKi927oam26nArPGM=; b=F3cXwbCRvOHP3gbBZvxfny/7bn14kR4m3haGJXQcOv8X9bn9VnAOELyI6gdUcRQG04 zFHIlXIJCNjuHSWPMT3d8EJgnampID2xUG+Po4BniUVSno91W76YXjPJ3V1nXeT0cPu0 AlVbfUNsiv4hG+IHcOFbSE6M06BzgkJSZoLlDp90PGD5tMAPy30Rz+/s1WRJvza5ktqR 1isV/LJP60RKZskkGetDuGGPDxe1wneVw4F/+aRjEmbu3LpoxtbteEryCWwM88kYBTbC f2J7VR/prAUeGepu4GtrUbfQQuRwPE39GFIJEx6vWUjq4cMiDq63kdcDVG//JQg8s3MP 7o4g== X-Forwarded-Encrypted: i=1; AJvYcCXG9lt3RbdCeuhHfVHPqfSkbhbX7YNUR+eIY7hXlDngoVZtio7JTqVTzDEChZ1DB3yViTaGe+AZHwSmB6Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yzt+4gJkcCybRafB2xLUdh5kxJMyR/9RsTcDj6TIPiT3yzMvNSq r986L41M/Fr8bx2PJ5Pj89TVGuG3MItkZWkfvFXFMQ9Ob2SdGGhHv2jR X-Gm-Gg: AZuq6aJDO7QmhmWWHqln+E6voaZYSW7XDEoKynP8Zruy6cYUFgai8LeNB3kDtkACeep LT5rMPgbvlQpKrnr/v0fAk/LXKvXdMrNU8Dvld6v5AiS1OWtFesdlxeiFPNOq9uMcnknFSD0EV4 Eu6a1HodliQzSMzmYgDq/wrV3UHeMJSO9YfL6BqivxuBXw3BcpOzMKizkkBSg+PGgZeJ54bzbI3 cmebd44Ls1mQ/wynWfOgkQHXzSpIrPicr6CCOhPqqpIAP2jMTBo2O3pU4h80xO7/Ee/0QNiSpN1 2mXuG1o7fkXpTAefFjDihq2njs314juTf3ExHMqwFMe08dtqiRLaYxY5Y8ux1F0Gk+xB53SB+hd cZYE1Z+n2DmxhASG9cvSWmuD3vaIsn7vwp4VyysIDk2BinaQPP9j4VqrWaSPDp0k8pXCvt5LcAb c3p7S+qxRdsXwozg9yPx+jElvy8AgoaUVGK+Wn/QrO/15zwFz/Mz+LRbiedlOvIllZKdoeh7zCp z5IHMdRviKlA5HKDA== X-Received: by 2002:a05:6000:604:b0:435:8ad8:b7a with SMTP id ffacd0b85a97d-4396f181362mr4957590f8f.46.1771666808395; Sat, 21 Feb 2026 01:40:08 -0800 (PST) Received: from jernej-laptop.localnet (86-58-126-118.dynamic.telemach.net. [86.58.126.118]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43970d3ff6dsm4555030f8f.25.2026.02.21.01.40.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Feb 2026 01:40:08 -0800 (PST) From: Jernej =?UTF-8?B?xaBrcmFiZWM=?= To: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Chen-Yu Tsai , Samuel Holland , Richard Genoud Cc: Wentao Liang , Maxime Ripard , Thomas Petazzoni , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Richard Genoud Subject: Re: [PATCH 2/6] mtd: rawnand: sunxi: fix sunxi_nfc_hw_ecc_read_extra_oob Date: Sat, 21 Feb 2026 10:15:56 +0100 Message-ID: <5078855.31r3eYUQgx@jernej-laptop> In-Reply-To: <20260220161011.999642-3-richard.genoud@bootlin.com> References: <20260220161011.999642-1-richard.genoud@bootlin.com> <20260220161011.999642-3-richard.genoud@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Dne petek, 20. februar 2026 ob 17:10:07 Srednjeevropski standardni =C4=8Das= je Richard Genoud napisal(a): > When dumping the OOB, the bytes at the end where actually copied from > the beginning of the OOB instead of current_offset. >=20 > That leads to something like: > OOB: ff ff ff ff ff ff ff ff ea 19 00 3a 83 db aa 8d > OOB: 99 09 c8 9a 90 36 35 7d aa 15 13 07 3d 97 b2 a4 > OOB: a8 bb 19 b3 07 e9 f6 25 52 d7 1a 23 e2 7e 0a e4 > OOB: 52 8a 09 d2 1a 86 3d cf b4 99 43 13 d3 90 33 0b > OOB: ff ff ff ff ff ff ff ff ea 19 00 3a 83 db aa 8d > OOB: 99 09 c8 9a 90 36 35 7d aa 15 13 07 3d 97 b2 a4 > OOB: a8 bb 19 b3 07 e9 f6 25 52 d7 1a 23 e2 7e 0a e4 > OOB: 52 8a 09 d2 1a 86 3d cf b4 99 43 13 d3 90 33 0b > instead of: > OOB: ff ff ff ff ff ff ff ff ea 19 00 3a 83 db aa 8d > OOB: 99 09 c8 9a 90 36 35 7d aa 15 13 07 3d 97 b2 a4 > OOB: a8 bb 19 b3 07 e9 f6 25 52 d7 1a 23 e2 7e 0a e4 > OOB: 52 8a 09 d2 1a 86 3d cf b4 99 43 13 d3 90 33 0b > OOB: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff > OOB: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff > OOB: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff > OOB: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff > (example with BCH16, user data [8,0], no scrambling) >=20 > *cur_off (offset from the beginning of the page) was compared to offset > (offset from the beginning of the OOB), and then, the > nand_change_read_column_op() sets the current position to the beginning > of the OOB instead of OOB+offset >=20 > Fixes: 15d6f118285f ("mtd: rawnand: sunxi: Stop supporting ECC_HW_SYNDROM= E mode") > Signed-off-by: Richard Genoud Reviewed-by: Jernej Skrabec Best regards, Jernej