From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753309AbdHRNqY (ORCPT ); Fri, 18 Aug 2017 09:46:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36636 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752021AbdHRNqV (ORCPT ); Fri, 18 Aug 2017 09:46:21 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 81873356F6 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=longman@redhat.com Subject: Re: [PATCH v3 0/2] cpuset: Allow v2 behavior in v1 cgroup To: Tejun Heo Cc: Li Zefan , Johannes Weiner , linux-kernel@vger.kernel.org References: <1502998390-25283-1-git-send-email-longman@redhat.com> <20170818112950.GC491396@devbig577.frc2.facebook.com> From: Waiman Long Organization: Red Hat Message-ID: <5081078e-fe00-dca6-92a4-c6b3d3094794@redhat.com> Date: Fri, 18 Aug 2017 09:46:20 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20170818112950.GC491396@devbig577.frc2.facebook.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 18 Aug 2017 13:46:21 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/18/2017 07:29 AM, Tejun Heo wrote: > On Thu, Aug 17, 2017 at 03:33:08PM -0400, Waiman Long wrote: >> v2->v3: >> - Change the generic CGRP_ROOT_V2_MODE flag to a cpuset specific >> CGRP_ROOT_CPUSET_V2_MODE flag. >> >> v1->v2: >> - Drop the kernel command line option and use cgroupfs mount option >> instead to enable v2 controller behavior in v1 cgroup. >> >> v1: https://lkml.org/lkml/2017/8/15/570 > Waiman, patches look good to me but can you please take care of the > kbuild warnings on 32bit and maybe merge the two patches into one? The kbuild warning is in the __init code of the v1 patch for checking the boot time argument. The __init code was gone in the v3 patch. So if there is no further kbuild warning after a couple of days, I think it should be OK. Cheers, Longman