From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755005AbcIJUXo (ORCPT ); Sat, 10 Sep 2016 16:23:44 -0400 Received: from mout.web.de ([212.227.17.11]:64179 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751756AbcIJUXn (ORCPT ); Sat, 10 Sep 2016 16:23:43 -0400 Subject: [PATCH 02/13] DRBD-receiver: Delete an error message for a failed kmalloc_array() call To: drbd-dev@lists.linbit.com, Lars Ellenberg , Philipp Reisner References: <3566e764-27b8-82e5-1f8e-c613e5a3a5b1@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Wolfram Sang From: SF Markus Elfring Message-ID: <50817602-79d5-af47-8d97-6d6b01939e43@users.sourceforge.net> Date: Sat, 10 Sep 2016 22:23:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <3566e764-27b8-82e5-1f8e-c613e5a3a5b1@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:ePm+BFSA9X9dVLPFRm5/eGmq9o7ok0owZN9TW5RhNHR27eAW/0U xA83J/vjx+SiWIWyTGYa4HMXsBL81kEX2Eib8hR62bEWgCW2cN9FWruzKxH0DbtnLMno3P6 4nYsJ0Crh6K2FULk8QoqGk/qLqdq9dQ1lIuXDpXglWPkLy6u9Jv9iPLqHVweTVXS6GkaMBY qIvNvR6wtmVpzeqpSXI+g== X-UI-Out-Filterresults: notjunk:1;V01:K0:fjoccvUrWSw=:28rzzfzBOIoa5cba/IoRn8 leX12coYpUi4mBL023O/X4Z66poN5toi+0HSQ3DGNrLde+fK8Cw8tJVSpF7Qr6hYv0zRD2SDR MVU2/mBjbaMCOyW5lbUc4mjXqsP4qh6XGSwARHqnCXkxBZRflRyTB71dd4f+psSuuMDTtzBzz 1pm8lu7y6LZKCnV0AXWcyMbkfKn1f7CcFvwY1RpYpobMOIaYA/0g7BYdg3ElcTnll7u0HrV67 BhkwD5kws56jYT+aoCI1Xw2x+cVtPMco8W3a+AVMIE1XFOfnQ642NYG+3gYNnDUSqXTg2gdqW 9nwrO7ONPIzeVj7RJdE56xnSOGknDgtrB13TC1w41AIHeN7y8q+yQWuWkceVyn5/N5zuLq0qT T4maiBb3ZcjVAKVPz0X9HS1REb1LMLEkTJ4FwuDj5BNwpuciZumbdeC1T4LKpXVeuuImKm6Vh VC1NBvjn45Zk+GA24Al+8nzpIEjl/icccPppm+8C9KmT3s6potaJk0QYYiKiUZIjeoxtUl2KT gwY5cjyxWelchkfoMe6gF7PoKptw1y2Fe8FXC/kkf4sV1dvzpg/RrP1p+kGHrYjbkA+ZAJoDV knt3tkuOkXYCRAtjL7Tgkl2ZskZyMy4vT/7alRcXJTTD9RSz6ajYr3+NXoDyCVy6zSXX55//f OwYZNIrYHlBj7k3YYuLL2v5BIYYMNvMcU1+FryTUaG3sFsGHgjlpYWuygdI5fsnnnluOalZZ3 omJcOuHc0kdBvWNP3hfKX4Typ5n+WkccS2ppIvP/DNxjmRf1yxeLp5NmuPK5IVwI5zsfagGXm QiCgrlA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 10 Sep 2016 19:26:07 +0200 Omit an extra message for a memory allocation failure in this function. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- drivers/block/drbd/drbd_receiver.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c index 3be9fbf..dab3f74 100644 --- a/drivers/block/drbd/drbd_receiver.c +++ b/drivers/block/drbd/drbd_receiver.c @@ -4187,10 +4187,8 @@ static int receive_uuids(struct drbd_connection *connection, struct packet_info device = peer_device->device; p_uuid = kmalloc_array(UI_EXTENDED_SIZE, sizeof(*p_uuid), GFP_NOIO); - if (!p_uuid) { - drbd_err(device, "kmalloc of p_uuid failed\n"); + if (!p_uuid) return false; - } for (i = UI_CURRENT; i < UI_EXTENDED_SIZE; i++) p_uuid[i] = be64_to_cpu(p->uuid[i]); -- 2.10.0