From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3109C49EA7 for ; Thu, 24 Jun 2021 13:13:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B3BDF613F6 for ; Thu, 24 Jun 2021 13:13:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231265AbhFXNPU (ORCPT ); Thu, 24 Jun 2021 09:15:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229881AbhFXNPT (ORCPT ); Thu, 24 Jun 2021 09:15:19 -0400 Received: from mail-ot1-x32f.google.com (mail-ot1-x32f.google.com [IPv6:2607:f8b0:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7621FC061574 for ; Thu, 24 Jun 2021 06:13:00 -0700 (PDT) Received: by mail-ot1-x32f.google.com with SMTP id o17-20020a9d76510000b02903eabfc221a9so5541795otl.0 for ; Thu, 24 Jun 2021 06:13:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4SF5a3kJdcjfWJZpedrg2y4hs9MoI05TwLUsIxF/D4Q=; b=ZhRieZYzvRBPi0/6nnXVxybiLtozerYBMutruvdWEpnOZeSZ9wHm5HTX21AScLl+n0 Ak4LZ9jAEfp+CxLL0jBRqFjUMi/OTQsg45Sam4dO1r+eoHHVvBpMOaLzeKQZtaHRKzdE a8lEbNeg/RE8B19zl1lxQBjkYBDAeyaG5ZZZY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4SF5a3kJdcjfWJZpedrg2y4hs9MoI05TwLUsIxF/D4Q=; b=cODcjM72zBG6Amx7K5/xTcBsnql8ck52KRACPqFsNwn+hOwZnP2jC4rM4vRj3wr2Cm MulVIseyLxEZXZ/nJ/2pt0/7Vp49YzeVLAWTGnKzJhGCLd6kuymAzRlzahtQyTikpPMN xITOjyNSezy3qKdaKYImimgL0oEFT15Xro1pTdejxIIp3iM8oLV0gkZjF0VoWnFrsY/I eUNvCzLEdveF8WU/xqK7VMj8HL6lW5qVoSow7VLnC153i1LtPx+f2hd6SIyN9cRdpLEN 7cjbS0mQxdIPIhgHDlAtoX7wyemOoNSupa/AwZXxEX1+ctNxg61NB4Fle0PKMf3PTPp9 gdww== X-Gm-Message-State: AOAM530U6uKcTnOg0yTOhP7t5jU3Nc0lwX0aWTSgb9OJNmaihKcvpGkb NW2cH3fGnrW07soVJDDuhVFkbg== X-Google-Smtp-Source: ABdhPJxaH3NzKbqaBGkp4qCphwU/Avg8Jw0NOxVdPCxyIoNq2eACWJ7Mpdr/7V6l8+X4pmqjj3rVyQ== X-Received: by 2002:a9d:1444:: with SMTP id h62mr4687643oth.166.1624540379798; Thu, 24 Jun 2021 06:12:59 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id s2sm581628ooa.39.2021.06.24.06.12.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Jun 2021 06:12:59 -0700 (PDT) Subject: Re: [PATCH kunit-next] thunderbolt: test: Reinstate a few casts of bitfields To: David Gow , Brendan Higgins Cc: Mika Westerberg , linux-usb@vger.kernel.org, kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, kernel test robot , Shuah Khan References: <20210624084823.15031-1-davidgow@google.com> From: Shuah Khan Message-ID: <50840b08-5735-f63b-91b7-a7117a25d3da@linuxfoundation.org> Date: Thu, 24 Jun 2021 07:12:58 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210624084823.15031-1-davidgow@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/24/21 2:48 AM, David Gow wrote: > Partially revert "thunderbolt: test: Remove some casts which are no > longer required". It turns out that typeof() doesn't support bitfields, > so these still need to be cast to the appropriate enum. > > The only mention of typeof() and bitfields I can find is in the proposal > to standardise them: > http://www.open-std.org/jtc1/sc22/wg14/www/docs/n2619.htm > > This was caught by the kernel test robot: > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org/thread/FDKBHAV7QNLNFU5NBI2RKV56DWDSOLGM/ > > Fixes: 8f0877c26e ("thunderbolt: test: Remove some casts which are no longer required") > Reported-by: kernel test robot > Signed-off-by: David Gow > --- > > Whoops: I didn't notice this was broken earlier. If it's easier to just > revert the broken patch, that's fine, too. > Thanks for fixing this quickly. I will apply this on top of the broken patch. thanks, -- Shuah