From: David Ahern <dsahern@gmail.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>,
Stephane Eranian <eranian@google.com>,
LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
"mingo@elte.hu" <mingo@elte.hu>
Subject: Re: [BUG] perf list: --help option not implemented
Date: Mon, 22 Oct 2012 07:26:05 -0600 [thread overview]
Message-ID: <5085496D.30605@gmail.com> (raw)
In-Reply-To: <87r4orj7zc.fsf@sejong.aot.lge.com>
On 10/22/12 1:12 AM, Namhyung Kim wrote:
> It seems that commit cc5848213329 ("perf help: Remove use of die and
> handle errors") caused the problem - it changed the initial value of
> 'help_format' from HELP_FORMAT_MAN to HELP_FORMAT_NONE.
>
> The following patch works well for me:
>
> diff --git a/tools/perf/builtin-help.c b/tools/perf/builtin-help.c
> index 411ee5664e98..178b88ae3d2f 100644
> --- a/tools/perf/builtin-help.c
> +++ b/tools/perf/builtin-help.c
> @@ -414,7 +414,7 @@ static int show_html_page(const char *perf_cmd)
> int cmd_help(int argc, const char **argv, const char *prefix __maybe_unused)
> {
> bool show_all = false;
> - enum help_format help_format = HELP_FORMAT_NONE;
> + enum help_format help_format = HELP_FORMAT_MAN;
> struct option builtin_help_options[] = {
> OPT_BOOLEAN('a', "all", &show_all, "print all available commands"),
> OPT_SET_UINT('m', "man", &help_format, "show man page", HELP_FORMAT_MAN),
>
D'oh. Thanks for debugging, Namhyung.
Acked-by/Tested-by: David Ahern <dsahern@gmail.com>
next prev parent reply other threads:[~2012-10-22 13:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-19 8:27 Stephane Eranian
2012-10-19 8:46 ` Jiri Olsa
2012-10-22 7:12 ` Namhyung Kim
2012-10-22 8:32 ` Jiri Olsa
2012-10-22 13:26 ` David Ahern [this message]
2012-10-24 6:03 ` [tip:perf/urgent] perf help: Fix --help for builtins tip-bot for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5085496D.30605@gmail.com \
--to=dsahern@gmail.com \
--cc=acme@redhat.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome