mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavel Emelyanov <xemul@parallels.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Cyrill Gorcunov <gorcunov@openvz.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [rfc 0/2] Introducing VmFlags field into smaps output
Date: Tue, 23 Oct 2012 00:50:48 +0400	[thread overview]
Message-ID: <5085B1A8.4020609@parallels.com> (raw)
In-Reply-To: <20121022122934.d2e2fa57.akpm@linux-foundation.org>

On 10/22/2012 11:29 PM, Andrew Morton wrote:
> On Mon, 22 Oct 2012 23:14:52 +0400
> Cyrill Gorcunov <gorcunov@openvz.org> wrote:
> 
>> Hi guys, during c/r sessions we've found that there is no way at
>> the moment to fetch some VMA associated flags, such as mlock()
>> and madvise(), thus the patches in this series intorduce new field
>> into "smaps" output called VmFlags where all flags associated with
>> the particular VMA is shown in two letter mnemonic.
>>
>> Strictly speaking for c/r we only need mlock/madvise bits but it
>> has been said that providing just a few flags looks somehow inconsistent.
>> So all flags are here now.
>>
>> Please review. Comments and complains are quite welcome!
> 
> Sigh, it's still a pretty nasty-looking interface.  Better ideas are
> welcomed.

Maybe just a string of two-letter short names like

VmFlags: rd wr sh sr

?

I.e. in a way flags line looks in cpuinfo file.

> I joined the patches into one, massaged the changelog a bit and added a
> couple more paragraphs explaining why we're doing this to ourselves.

  parent reply	other threads:[~2012-10-22 20:50 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-22 19:14 Cyrill Gorcunov
2012-10-22 19:14 ` [rfc 1/2] [RFC] procfs: Add VmFlags field in " Cyrill Gorcunov
2012-10-22 19:14 ` [rfc 2/2] [RFC] procfs: Documantation -- Add VmFlags field description Cyrill Gorcunov
2012-10-22 19:29 ` [rfc 0/2] Introducing VmFlags field into smaps output Andrew Morton
2012-10-22 19:39   ` Cyrill Gorcunov
2012-10-22 20:50   ` Pavel Emelyanov [this message]
2012-10-22 20:56     ` Cyrill Gorcunov
2012-10-22 21:34       ` Cyrill Gorcunov
2012-10-22 21:51         ` Andrew Morton
2012-10-23  6:13           ` Cyrill Gorcunov
2012-10-23  6:30             ` Andrew Morton
2012-10-23  6:34               ` Cyrill Gorcunov
2012-10-23  7:15                 ` Cyrill Gorcunov
2012-10-23 21:30                   ` Andrew Morton
2012-10-23 21:46                     ` Cyrill Gorcunov
2012-10-23 21:59                       ` Cyrill Gorcunov
2012-10-23 22:32                         ` Peter Zijlstra
2012-10-23 23:56                           ` Stephen Rothwell
2012-10-24  6:30                           ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5085B1A8.4020609@parallels.com \
    --to=xemul@parallels.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=gorcunov@openvz.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome