mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ryan Mallon <rmallon@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Grant Likely <grant.likely@secretlab.ca>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] gpiolib: Refactor gpio_export
Date: Tue, 23 Oct 2012 09:15:28 +1100	[thread overview]
Message-ID: <5085C580.1080608@gmail.com> (raw)
In-Reply-To: <CACRpkdYcesZJHk7wn-YQdqcHjAzri_o0EqQys9xwq+6hyCnA_Q@mail.gmail.com>

On 23/10/12 09:13, Linus Walleij wrote:
> On Mon, Oct 22, 2012 at 2:39 AM, Ryan Mallon <rmallon@gmail.com> wrote:
> 
>> The gpio_export function uses nested if statements and the status
>> variable to handle the failure cases. This makes the function logic
>> difficult to follow. Refactor the code to abort immediately on failure
>> using goto. This makes the code slightly longer, but significantly
>> reduces the nesting and number of split lines and makes the code easier
>> to read.
> 
> Splendid, patch applied!

Thanks.

>> Signed-off-by: Ryan Mallon
> 
> Interesting that you sign off without an email address, I just added it
> thinking it was a mistake.

Whoops. Yeah, should be:

  Signed-off-by: Ryan Mallon <rmallon@gmail.com>

Thanks,
~Ryan


      reply	other threads:[~2012-10-22 22:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-22  0:39 Ryan Mallon
2012-10-22 22:13 ` Linus Walleij
2012-10-22 22:15   ` Ryan Mallon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5085C580.1080608@gmail.com \
    --to=rmallon@gmail.com \
    --cc=grant.likely@secretlab.ca \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome