From: Nicolas Dufresne <nicolas@ndufresne.ca>
To: Paul Kocialkowski <contact@paulk.fr>,
Alexandre Courbot <acourbot@chromium.org>,
Tomasz Figa <tfiga@chromium.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
Pawel Osciak <posciak@chromium.org>,
linux-media@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2] media: docs-rst: Document m2m stateless video decoder interface
Date: Thu, 04 Oct 2018 14:10:04 -0400 [thread overview]
Message-ID: <5085f73bc44424b20f1bd0dc1332d9baabecb090.camel@ndufresne.ca> (raw)
In-Reply-To: <f1fa989b372b514f0a7534057de80b0c453cc8a3.camel@paulk.fr>
[-- Attachment #1: Type: text/plain, Size: 1626 bytes --]
Le jeudi 04 octobre 2018 à 14:47 +0200, Paul Kocialkowski a écrit :
> > + Instance of struct v4l2_ctrl_h264_scaling_matrix, containing the scaling
> > + matrix to use when decoding the next queued frame. Applicable to the H.264
> > + stateless decoder.
> > +
> > +``V4L2_CID_MPEG_VIDEO_H264_SLICE_PARAM``
>
> Ditto with "H264_SLICE_PARAMS".
>
> > + Array of struct v4l2_ctrl_h264_slice_param, containing at least as many
> > + entries as there are slices in the corresponding ``OUTPUT`` buffer.
> > + Applicable to the H.264 stateless decoder.
> > +
> > +``V4L2_CID_MPEG_VIDEO_H264_DECODE_PARAM``
> > + Instance of struct v4l2_ctrl_h264_decode_param, containing the high-level
> > + decoding parameters for a H.264 frame. Applicable to the H.264 stateless
> > + decoder.
>
> Since we require all the macroblocks to decode one frame to be held in
> the same OUTPUT buffer, it probably doesn't make sense to keep
> DECODE_PARAM and SLICE_PARAM distinct.
>
> I would suggest merging both in "SLICE_PARAMS", similarly to what I
> have proposed for H.265: https://patchwork.kernel.org/patch/10578023/
>
> What do you think?
I don't understand why we add this arbitrary restriction of "all the
macroblocks to decode one frame". The bitstream may contain multiple
NALs per frame (e.g. slices), and stateless API shall pass each NAL
separately imho. The driver can then decide to combine them if needed,
or to keep them seperate. I would expect most decoder to decode each
slice independently from each other, even though they write into the
same frame.
Nicolas
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2018-10-04 18:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 8:11 Alexandre Courbot
2018-10-04 12:41 ` Paul Kocialkowski
2018-10-09 5:58 ` Tomasz Figa
2018-10-12 12:28 ` Paul Kocialkowski
2018-10-04 12:47 ` Paul Kocialkowski
2018-10-04 18:10 ` Nicolas Dufresne [this message]
2018-10-05 17:10 ` Paul Kocialkowski
2018-10-08 10:21 ` Hans Verkuil
2018-10-09 7:36 ` Tomasz Figa
2018-10-12 11:52 ` Paul Kocialkowski
2018-10-09 7:30 ` Tomasz Figa
2018-10-09 17:48 ` Paul Kocialkowski
2018-10-08 11:01 ` Hans Verkuil
2018-10-09 7:41 ` Tomasz Figa
2018-10-09 8:07 ` Hans Verkuil
2018-10-09 5:48 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5085f73bc44424b20f1bd0dc1332d9baabecb090.camel@ndufresne.ca \
--to=nicolas@ndufresne.ca \
--cc=acourbot@chromium.org \
--cc=contact@paulk.fr \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=posciak@chromium.org \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®