From: Randy Dunlap <rdunlap@xenotime.net>
To: Fabio Estevam <fabio.estevam@freescale.com>
Cc: broonie@opensource.wolfsonmicro.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, festevam@gmail.com
Subject: Re: [PATCH] regmap: Fix printing of size_t variable
Date: Thu, 25 Oct 2012 15:52:32 -0700 [thread overview]
Message-ID: <5089C2B0.6050900@xenotime.net> (raw)
In-Reply-To: <1351181238-25568-1-git-send-email-fabio.estevam@freescale.com>
On 10/25/2012 09:07 AM, Fabio Estevam wrote:
> val_bytes is of 'size_t', so it should be printed as '%zu'.
>
> Fixes the following build warning on x86:
>
> drivers/base/regmap/regmap.c:872:4: warning: format '%d' expects argument of type 'int', but argument 5 has type 'size_t' [-Wformat]
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Randy Dunlap <rdunlap@xenotime.net>
http://marc.info/?l=linux-kernel&m=135041943424273&w=2
> ---
> drivers/base/regmap/regmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c
> index 0585726..cc90dfc 100644
> --- a/drivers/base/regmap/regmap.c
> +++ b/drivers/base/regmap/regmap.c
> @@ -869,7 +869,7 @@ static int _regmap_raw_write(struct regmap *map, unsigned int reg,
>
> /* If the write goes beyond the end of the window split it */
> while (val_num > win_residue) {
> - dev_dbg(map->dev, "Writing window %d/%d\n",
> + dev_dbg(map->dev, "Writing window %d/%zu\n",
> win_residue, val_len / map->format.val_bytes);
> ret = _regmap_raw_write(map, reg, val, win_residue *
> map->format.val_bytes);
--
~Randy
next prev parent reply other threads:[~2012-10-25 22:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 16:07 Fabio Estevam
2012-10-25 17:55 ` Mark Brown
2012-10-25 22:52 ` Randy Dunlap [this message]
2012-10-27 21:14 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5089C2B0.6050900@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome