From: "Jan Beulich" <jbeulich@suse.com>
To: <jinsong.liu@intel.com>
Cc: <xen-devel@lists.xen.org>, <konrad.wilk@oracle.com>,
<linux-kernel@vger.kernel.org>
Subject: RE: [Xen-devel] [PATCH 1/2] Xen acpi pad implement
Date: Fri, 26 Oct 2012 13:02:03 +0100 [thread overview]
Message-ID: <508A89CB020000780008E6ED@nat28.tlf.novell.com> (raw)
In-Reply-To: <DE8DF0795D48FD4CA783C40EC82923353723C7@SHSMSX101.ccr.corp.intel.com>
>>> "Liu, Jinsong" <jinsong.liu@intel.com> 10/26/12 8:18 AM >>>
>> +static struct acpi_driver xen_acpi_pad_driver = {
>> + .name = "processor_aggregator",
>> + .class = ACPI_PROCESSOR_AGGREGATOR_CLASS,
>> + .ids = pad_device_ids,
>> + .ops = {
>> + .add = xen_acpi_pad_add,
>
>.remove?
>
>[Jinsong] .remove method not used by any logic now (any possible point use it?), so we remove it from our former patch.
Unless there is technical difficulty implementing it, I wouldn't defer adding that code until the point where something doesn't work anymore.
>Overall I'd recommend taking a look at the cleaned up driver in
>our kernels.
>
>[Jinsong] What's your point here?
There's quite a bit of cleanup/simplification potential here, and rather than pointing the pieces out individually I would think comparing with what we have in production use might be worthwhile. But that's up to you of course.
Jan
next prev parent reply other threads:[~2012-10-26 12:02 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 12:19 Liu, Jinsong
2012-10-25 14:23 ` [Xen-devel] " Jan Beulich
2012-10-26 6:18 ` Liu, Jinsong
2012-10-26 12:02 ` Jan Beulich [this message]
2012-10-26 12:37 ` Liu, Jinsong
2012-10-26 14:00 ` Liu, Jinsong
2012-10-26 20:14 ` Konrad Rzeszutek Wilk
2012-10-29 3:38 ` Liu, Jinsong
2012-10-29 12:39 ` Konrad Rzeszutek Wilk
2012-10-30 7:58 ` Liu, Jinsong
2012-10-30 13:37 ` Konrad Rzeszutek Wilk
2012-10-30 15:18 ` Liu, Jinsong
2012-10-31 13:51 ` Konrad Rzeszutek Wilk
2012-10-31 15:07 ` Liu, Jinsong
2012-11-01 6:34 ` Liu, Jinsong
2012-11-02 16:49 ` Konrad Rzeszutek Wilk
2012-11-03 12:16 ` Liu, Jinsong
2012-11-05 8:29 ` Jan Beulich
2012-11-05 15:16 ` Stefano Stabellini
2012-11-06 5:48 ` Liu, Jinsong
2012-11-06 6:15 ` Liu, Jinsong
2012-11-06 14:56 ` Stefano Stabellini
2012-11-06 16:23 ` Liu, Jinsong
2012-11-06 16:43 ` Konrad Rzeszutek Wilk
2012-11-07 12:58 ` Liu, Jinsong
2012-11-07 16:03 ` Konrad Rzeszutek Wilk
2012-11-07 16:52 ` Liu, Jinsong
2012-11-08 1:08 ` Konrad Rzeszutek Wilk
2012-11-06 18:28 ` Shuah Khan
2012-11-07 13:06 ` Liu, Jinsong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508A89CB020000780008E6ED@nat28.tlf.novell.com \
--to=jbeulich@suse.com \
--cc=jinsong.liu@intel.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®