mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Richard Retanubun <richardretanubun@ruggedcom.com>
To: Greg KH <greg@kroah.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
	Lennart Sorensen <lsorense@csclub.uwaterloo.ca>,
	Tang Nguyen <TangNguyen@ruggedcom.com>,
	"m.grzeschik@pengutronix.de" <m.grzeschik@pengutronix.de>,
	Arvid Brodin <Arvid.Brodin@xdin.com>,
	linux-usb mailing list <linux-usb@vger.kernel.org>,
	"bigeasy@linutronix.de" <bigeasy@linutronix.de>
Subject: Re: kmemleak report on isp1763 and sierra MC8705
Date: Mon, 29 Oct 2012 16:47:04 -0400	[thread overview]
Message-ID: <508EEB48.9070508@ruggedcom.com> (raw)
In-Reply-To: <20121026233509.GA26646@kroah.com>

On 26/10/12 07:35 PM, Greg KH wrote:
> On Fri, Oct 26, 2012 at 05:57:23PM -0400, Richard Retanubun wrote:
>> Hi Guys,
>>
>> I am debugging a reported kmemleak involving a sierra wireless MC8705 connected
>> through isp1763 on powerpc linux-3.0.22
>
> Does this also happen on 3.6.3?
>
> thanks,
>
> greg k-h

Hi Greg,

Unfortunately, it is not trivial for us to update the kernel on this platform,
Is there a specific experiment/patch I should look at for 3.0.22?

I will be attempting to use 3.6.3 on another platform, but this may take some time.

I am thinking there may be an action that can be done at /sysfs or /procfs to
do the disconnect without actually removing the power to the device.
I tried "echo 1 > /sys/bus/usb/drivers/usb/2-1.2/remove" and then take down the power
but this produced the same leak signature even before I take down the power.

Update on trigger to problem
============================
This will happen as the modem is powered down and /dev/ttyUSB from sierra is teared down
either by powering it off/removing it, or sending at!reset.

It does not happen when the same thing is done using a simple usb to serial converter (pl2303)

Focusing down on one of the dumps:

unreferenced object 0xd3849740 (size 8):
   comm "khubd", pid 1026, jiffies 232553037 (age 506.597s)
   hex dump (first 8 bytes):
     4d 43 38 37 30 35 00 00                          MC8705..
   backtrace:
     [<e30efd74>] usb_cache_string+0x74/0xac [usbcore]
     [<e30e77bc>] usb_enumerate_device+0x44/0xf8 [usbcore]
     [<e30e7aa0>] usb_new_device+0x3c/0x13c [usbcore]
     [<e30e9824>] hub_thread+0xc8c/0x1544 [usbcore]
     [<c0043aa8>] kthread+0x7c/0x80
     [<c000ed48>] kernel_thread+0x4c/0x68

I have a small question. How does the memory kmalloc-ed() in usb_cache_string is supposed to be released?
(during usb_serial_disconnect()?) Is the sierra driver is supposed to participate
in the tear down process (in sierra_release() maybe) and not doing something that is expected?
I am still missing the link between the actions done by the hub_thread() for the caching the stings
and the sierra driver code.

Thanks a lot for your time.

  reply	other threads:[~2012-10-29 20:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-26 21:57 Richard Retanubun
2012-10-26 23:35 ` Greg KH
2012-10-29 20:47   ` Richard Retanubun [this message]
2012-10-29 21:11     ` Greg KH
2012-10-29 22:14     ` Alan Stern
2012-11-09 22:14       ` Richard Retanubun
2012-11-10 14:30         ` Johan Hovold
2012-11-14 17:12           ` Richard Retanubun
2012-11-14 17:52             ` Johan Hovold
2012-11-21  1:15               ` Greg Kroah-Hartman
2012-11-25 14:24                 ` Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=508EEB48.9070508@ruggedcom.com \
    --to=richardretanubun@ruggedcom.com \
    --cc=Arvid.Brodin@xdin.com \
    --cc=TangNguyen@ruggedcom.com \
    --cc=bigeasy@linutronix.de \
    --cc=catalin.marinas@arm.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=lsorense@csclub.uwaterloo.ca \
    --cc=m.grzeschik@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome