From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750897AbdE1S0d (ORCPT ); Sun, 28 May 2017 14:26:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50126 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750798AbdE1S0b (ORCPT ); Sun, 28 May 2017 14:26:31 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0C851C057FA4 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=hdegoede@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 0C851C057FA4 Subject: Re: [PATCH v5 2/7] staging: atomisp: Do not call dev_warn with a NULL device To: Alan Cox Cc: Lee Jones , Chen-Yu Tsai , linux-kernel@vger.kernel.org, Linux Media Mailing List References: <20170528123040.18555-1-hdegoede@redhat.com> <20170528123040.18555-2-hdegoede@redhat.com> <20170528180853.5a6c8f11@alans-desktop> From: Hans de Goede Message-ID: <508ccb9b-fcde-b040-593d-5e8552db5f24@redhat.com> Date: Sun, 28 May 2017 20:26:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <20170528180853.5a6c8f11@alans-desktop> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Sun, 28 May 2017 18:26:31 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 28-05-17 19:08, Alan Cox wrote: > On Sun, 28 May 2017 14:30:35 +0200 > Hans de Goede wrote: > >> Do not call dev_warn with a NULL device, this silence the following 2 >> warnings: >> >> [ 14.392194] (NULL device *): Failed to find gmin variable gmin_V2P8GPIO >> [ 14.392257] (NULL device *): Failed to find gmin variable gmin_V1P8GPIO >> >> We could switch to using pr_warn for dev == NULL instead, but as comments >> in the source indicate, the check for these 2 special gmin variables with >> a NULL device is a workaround for 2 specific evaluation boards, so >> completely silencing the missing warning for these actually is a good >> thing. > > At which point real missing variables won't get reported so NAK. I think > the right fix is to make the offending callers pass > > subdev->dev The code for the special v1p8 / v2p8 gpios is ugly as sin, it operates on a global v2p8_gpio value rather then storing info in the gmin_subdev struct, as such passing the subdev->dev pointer would be simply wrong. AFAICT the v1p8 / v2p8 gpio code is the only caller passing in a NULL pointer and as said since thisv1p8 / v2p8 gpio code is only for some special evaluation boards, silencing the error when these variables are not present actually is the right thing to do. > which if my understanding of the subdevices is correct should pass the > right valid device field from the atomisp. > > Please also cc me if you are proposing patches this driver - and also > linux-media. Sorry about that, I messed up my git send-email foo and send this to a wrong set of addresses (and also added v5 in the subject which should not be there) I did send out a fresh-copy with the full 7 patch patch-set directly after CTRL+c-ing this wrong send-email (which only got the first 3 patches send). Regards, Hans