From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
broonie@kernel.org, vkoul@kernel.org
Cc: robh@kernel.org, devicetree@vger.kernel.org,
yung-chuan.liao@linux.intel.com, sanyog.r.kale@intel.com,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH v2 3/5] soundwire: qcom: add static port map support
Date: Thu, 11 Mar 2021 14:29:14 +0000 [thread overview]
Message-ID: <508f875f-6fed-9bfc-5f3e-297e4c21ec29@linaro.org> (raw)
In-Reply-To: <cc812a5b-c3c3-bb46-f2fe-3e0a14cf0524@linux.intel.com>
On 09/03/2021 16:10, Pierre-Louis Bossart wrote:
>
>
>
>> list_for_each_entry(m_rt, &bus->m_rt_list, bus_node) {
>> @@ -473,8 +475,13 @@ static int qcom_swrm_compute_params(struct
>> sdw_bus *bus)
>> }
>> list_for_each_entry(s_rt, &m_rt->slave_rt_list, m_rt_node) {
>> + slave = s_rt->slave;
>> list_for_each_entry(p_rt, &s_rt->port_list, port_node) {
>> - pcfg = &ctrl->pconfig[i];
>> + m_port = slave->m_port_map[_rtp->num - 1];
>> + if (m_port)
>> + pcfg = &ctrl->pconfig[m_port - 1];
>> + else
>> + pcfg = &ctrl->pconfig[i];
>
> Maybe add a short comment on port allocation, I had to think a bit to
> figure out why the -1 was required on both peripheral and manager but it
> is not below [1]
I agree, will add some comment here to explain the offsets correctly!
--srini
>
>> p_rt->transport_params.port_num = p_rt->num;
>> p_rt->transport_params.sample_interval =
>> pcfg->si + 1;
>> @@ -535,8 +542,10 @@ static int qcom_swrm_stream_alloc_ports(struct
>> qcom_swrm_ctrl *ctrl,
>> struct sdw_master_runtime *m_rt;
>> struct sdw_slave_runtime *s_rt;
>> struct sdw_port_runtime *p_rt;
>> + struct sdw_slave *slave;
>> unsigned long *port_mask;
>> int i, maxport, pn, nports = 0, ret = 0;
>> + unsigned int m_port;
>> mutex_lock(&ctrl->port_lock);
>> list_for_each_entry(m_rt, &stream->master_list, stream_node) {
>> @@ -549,9 +558,15 @@ static int qcom_swrm_stream_alloc_ports(struct
>> qcom_swrm_ctrl *ctrl,
>> }
>> list_for_each_entry(s_rt, &m_rt->slave_rt_list, m_rt_node) {
>> + slave = s_rt->slave;
>> list_for_each_entry(p_rt, &s_rt->port_list, port_node) {
>> + m_port = slave->m_port_map[p_rt->num - 1];
>> /* Port numbers start from 1 - 14*/
>> - pn = find_first_zero_bit(port_mask, maxport);
>> + if (m_port)
>> + pn = m_port;
>> + else
>> + pn = find_first_zero_bit(port_mask, maxport);
>
> [1]
>
>> +
>> if (pn > (maxport)) {
>> dev_err(ctrl->dev, "All ports busy\n");
>> ret = -EBUSY;
>>
next prev parent reply other threads:[~2021-03-11 14:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 14:15 [PATCH v2 0/5] soundwire: " Srinivas Kandagatla
2021-03-09 14:15 ` [PATCH v2 1/5] soundwire: add static port mapping support Srinivas Kandagatla
2021-03-09 14:15 ` [PATCH v2 2/5] soundwire: qcom: update port map allocation bit mask Srinivas Kandagatla
2021-03-09 15:55 ` Pierre-Louis Bossart
2021-03-11 14:29 ` Srinivas Kandagatla
2021-03-09 14:15 ` [PATCH v2 3/5] soundwire: qcom: add static port map support Srinivas Kandagatla
2021-03-09 16:10 ` Pierre-Louis Bossart
2021-03-11 14:29 ` Srinivas Kandagatla [this message]
2021-03-09 14:15 ` [PATCH v2 4/5] ASoC: dt-bindings: wsa881x: add bindings for port mapping Srinivas Kandagatla
2021-03-09 17:19 ` Rob Herring
2021-03-09 14:15 ` [PATCH v2 5/5] ASoC: codecs: wsa881x: add static port map support Srinivas Kandagatla
2021-03-09 16:08 ` kernel test robot
2021-03-09 20:31 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508f875f-6fed-9bfc-5f3e-297e4c21ec29@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=robh@kernel.org \
--cc=sanyog.r.kale@intel.com \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®