From: Behan Webster <behanw@converseincode.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: balbi@ti.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Helper macros used for replacing the use of VLAIS
Date: Tue, 30 Oct 2012 15:35:24 -0400 [thread overview]
Message-ID: <50902BFC.4090309@converseincode.com> (raw)
In-Reply-To: <20121030192021.GA1979@kroah.com>
On 12-10-30 03:20 PM, Greg KH wrote:
> On Tue, Oct 30, 2012 at 02:25:19PM -0400, Behan Webster wrote:
>> The use of variable length arrays in structs (VLAIS) in the Linux Kernel code
>> precludes the use of compilers which don't implement VLAIS (for instance the
>> Clang compiler). This new header file contains macros which can be used to
>> calculate the size and offset of variables in an allocated buffer of memory
>> taking into account alignment issues.
>>
>> Signed-off-by: Behan Webster <behanw@converseincode.com>
>> ---
>> include/linux/valign.h | 87 ++++++++++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 87 insertions(+)
>> create mode 100644 include/linux/valign.h
> You sent the same patch here, to two different trees (usb and
> networking). That's not good, what happens if they both apply them?
Good point. My mistake.
People in both subsystems needed to see the patch which is why I sent them.
What would have been a better approach? And how can I fix this?
Behan
--
Behan Webster
behanw@converseincode.com
next prev parent reply other threads:[~2012-10-30 19:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 18:25 [PATCH 0/2] Removing the use of VLAIS from the Linux Kernel Behan Webster
2012-10-30 18:25 ` [PATCH 1/2] Helper macros used for replacing the use of VLAIS Behan Webster
2012-10-30 19:20 ` Greg KH
2012-10-30 19:35 ` Behan Webster [this message]
2012-10-30 19:40 ` Greg KH
2012-10-30 18:25 ` [PATCH 2/2] Remove VLAIS usage from gadget code Behan Webster
2012-11-01 15:38 ` Joseph Glanville
2012-10-30 18:42 [PATCH 0/2] Removing the use of VLAIS from netfilter Behan Webster
2012-10-30 18:42 ` [PATCH 1/2] Helper macros used for replacing the use of VLAIS Behan Webster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50902BFC.4090309@converseincode.com \
--to=behanw@converseincode.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome