From: Sarah Nadi <snadi@uwaterloo.ca>
To: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org
Cc: mst@redhat.com, daniel@numascale-asia.com, sp@numascale.com,
linux-kernel@vger.kernel.org
Subject: PATCH: Remove redundant #ifdef check in arch/x86/kernel/apic/bigsmp_32.c
Date: Thu, 01 Nov 2012 14:06:44 -0400 [thread overview]
Message-ID: <5092BA34.5030009@uwaterloo.ca> (raw)
From: Sarah Nadi <snadi@uwaterloo.ca>
Based on v3.5-rc1, #ifdef check in arch/x86/kernel/apic/bigsmp_32.c is
redundant as SMP will always be selected for the file to compile any
ways (file compiles when X86_BIGSMP is selected, and X86_BIGSMP depends
on SMP). The first block is always selected, and #else code block is
therefore always dead. See patch below.
--- linux/arch/x86/kernel/apic/bigsmp_32.c.orig 2012-11-01
13:53:24.781158327 -0400
+++ linux/arch/x86/kernel/apic/bigsmp_32.c 2012-11-01
13:54:39.501438248 -0400
@@ -28,11 +28,7 @@ static int bigsmp_apic_id_registered(voi
static const struct cpumask *bigsmp_target_cpus(void)
{
-#ifdef CONFIG_SMP
return cpu_online_mask;
-#else
- return cpumask_of(0);
-#endif
}
static unsigned long bigsmp_check_apicid_used(physid_mask_t *map, int
apicid)
Signed-off-by: Sarah Nadi <snadi@uwaterloo.ca>
reply other threads:[~2012-11-01 18:20 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5092BA34.5030009@uwaterloo.ca \
--to=snadi@uwaterloo.ca \
--cc=daniel@numascale-asia.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mst@redhat.com \
--cc=sp@numascale.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome