mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jan Beulich" <jbeulich@suse.com>
To: <rostedt@goodmis.org>, <sqazi@google.com>
Cc: <peterz@infradead.org>, <tglx@linutronix.de>,
	<torvalds@linux-foundation.org>, <hpa@linux.intel.com>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [PATCH] x86: Don't clobber top of pt_regs in nested NMI
Date: Thu, 01 Nov 2012 19:53:00 +0000	[thread overview]
Message-ID: <5092D31C020000780008EB6B@nat28.tlf.novell.com> (raw)
In-Reply-To: <1351731872.4004.112.camel@gandalf.local.home>

>>> Steven Rostedt <rostedt@goodmis.org> 11/01/12 2:04 AM >>>
>On Mon, 2012-10-01 at 17:29 -0700, Salman Qazi wrote:
>> @@ -1826,12 +1832,15 @@ repeat_nmi:
>>       * is benign for the non-repeat case, where 1 was pushed just above
>>       * to this very stack slot).
>>       */
>> -    movq $1, 5*8(%rsp)
>> +    movq $1, 10*8(%rsp)
>>  
>>      /* Make another copy, this one may be modified by nested NMIs */
>> +    addq $(10*8), %rsp
>
>This breaks the CFI magic.
>
>>      .rept 5
>> -    pushq_cfi 4*8(%rsp)
>> +    pushq_cfi -6*8(%rsp)
>>      .endr
>> +    subq $(5*8), %rsp
>
>So does this.
>
>This needs to be annotated correctly before I can push it out. But the
>good news is, I stressed tested this change, and it all works out.
>
>Jan, can you help out here?

There doesn't appear to be anything special about these adjustments, so I
don't see what help would be required here - it ought to be the normal use
of CFI_ADJUST_CFA_OFFSET that needs adding.

Jan


  reply	other threads:[~2012-11-01 19:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-02  0:26 [PATCH] The nested NMI modifies the place (instruction, flags and stack) Salman Qazi
2012-10-02  0:29 ` [PATCH] [PATCH] x86: Don't clobber top of pt_regs in nested NMI Salman Qazi
2012-11-01  1:04   ` Steven Rostedt
2012-11-01 19:53     ` Jan Beulich [this message]
2012-11-01 20:37       ` Steven Rostedt
2012-11-02 13:51       ` Steven Rostedt
2012-11-02 13:53         ` Steven Rostedt
2012-11-02 14:09           ` Jan Beulich
2012-11-02 14:11             ` Steven Rostedt
2012-11-02 19:37   ` [tip:x86/asm] " tip-bot for Salman Qazi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5092D31C020000780008EB6B@nat28.tlf.novell.com \
    --to=jbeulich@suse.com \
    --cc=hpa@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=sqazi@google.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®