From: Boaz Harrosh <bharrosh@panasas.com>
To: Jeff Layton <jlayton@samba.org>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>, <axboe@kernel.dk>,
<lucho@ionkov.net>, <tytso@mit.edu>, <sage@inktank.com>,
<ericvh@gmail.com>, <mfasheh@suse.com>, <dedekind1@gmail.com>,
<adrian.hunter@intel.com>, <dhowells@redhat.com>,
<sfrench@samba.org>, <jlbec@evilplan.org>, <rminnich@sandia.gov>,
<linux-cifs@vger.kernel.org>, <jack@suse.cz>,
<martin.petersen@oracle.com>, <neilb@suse.de>,
<david@fromorbit.com>, <linux-kernel@vger.kernel.org>,
<linux-mm@kvack.org>, <linux-mtd@lists.infradead.org>,
<linux-fsdevel@vger.kernel.org>,
<v9fs-developer@lists.sourceforge.net>,
<ceph-devel@vger.kernel.org>, <linux-ext4@vger.kernel.org>,
<linux-afs@lists.infradead.org>, <ocfs2-devel@oss.oracle.com>
Subject: Re: [PATCH 3/3] fs: Fix remaining filesystems to wait for stable page writeback
Date: Thu, 1 Nov 2012 15:23:54 -0700 [thread overview]
Message-ID: <5092F67A.2060203@panasas.com> (raw)
In-Reply-To: <20121101162254.03dbbd9a@tlielax.poochiereds.net>
On 11/01/2012 01:22 PM, Jeff Layton wrote:
> Hmm...I don't know...
>
> I've never been crazy about using the page lock for this, but in the
> absence of a better way to guarantee stable pages, it was what I ended
> up with at the time. cifs_writepages will hold the page lock until
> kernel_sendmsg returns. At that point the TCP layer will have copied
> off the page data so it's safe to release it.
>
> With this change though, we're going to end up blocking until the
> writeback flag clears, right? And I think that will happen when the
> reply comes in? So, we'll end up blocking for much longer than is
> really necessary in page_mkwrite with this change.
>
Hmm OK, that is a very good point. In that case it is just a simple
nack on Darrick's hunk to cifs. cifs is fine and should not be touched
Boaz
next prev parent reply other threads:[~2012-11-01 22:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 7:58 [RFC PATCH v2 0/3] mm/fs: Implement faster stable page writes on filesystems Darrick J. Wong
2012-11-01 7:58 ` [PATCH 1/3] bdi: Track users that require stable page writes Darrick J. Wong
2012-11-01 13:31 ` Jan Kara
2012-11-01 18:21 ` Boaz Harrosh
2012-11-01 18:57 ` Darrick J. Wong
2012-11-01 22:56 ` Boaz Harrosh
2012-11-01 23:15 ` Jan Kara
2012-11-01 7:58 ` [PATCH 2/3] mm: Only enforce stable page writes if the backing device requires it Darrick J. Wong
2012-11-01 13:28 ` Jan Kara
2012-11-01 7:58 ` [PATCH 3/3] fs: Fix remaining filesystems to wait for stable page writeback Darrick J. Wong
2012-11-01 12:36 ` Jan Kara
2012-11-01 18:43 ` Boaz Harrosh
2012-11-01 20:22 ` Jeff Layton
2012-11-01 22:23 ` Boaz Harrosh [this message]
2012-11-01 22:47 ` Darrick J. Wong
2012-11-02 0:36 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5092F67A.2060203@panasas.com \
--to=bharrosh@panasas.com \
--cc=adrian.hunter@intel.com \
--cc=axboe@kernel.dk \
--cc=ceph-devel@vger.kernel.org \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=dedekind1@gmail.com \
--cc=dhowells@redhat.com \
--cc=ericvh@gmail.com \
--cc=jack@suse.cz \
--cc=jlayton@samba.org \
--cc=jlbec@evilplan.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-mtd@lists.infradead.org \
--cc=lucho@ionkov.net \
--cc=martin.petersen@oracle.com \
--cc=mfasheh@suse.com \
--cc=neilb@suse.de \
--cc=ocfs2-devel@oss.oracle.com \
--cc=rminnich@sandia.gov \
--cc=sage@inktank.com \
--cc=sfrench@samba.org \
--cc=tytso@mit.edu \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome