From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753913AbbKBPeO (ORCPT <rfc822;w@1wt.eu>);
	Mon, 2 Nov 2015 10:34:14 -0500
Received: from mout.kundenserver.de ([212.227.126.131]:50453 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751373AbbKBPeM (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 2 Nov 2015 10:34:12 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>, tglx@linutronix.de,
        Heiko Stuebner <heiko@sntech.de>, linux-kernel@vger.kernel.org,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org>,
        john.stultz@linaro.org, Caesar Wang <wxt@rock-chips.com>
Subject: Re: [PATCH 03/22] clocksource/drivers/rockchip: Make the driver more compatible
Date: Mon, 02 Nov 2015 16:33:27 +0100
Message-ID: <5093304.EN6Bc2EjLr@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1446469011-22710-3-git-send-email-daniel.lezcano@linaro.org>
References: <1446469011-22710-1-git-send-email-daniel.lezcano@linaro.org> <1446469011-22710-3-git-send-email-daniel.lezcano@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:hlVu2VGVSlf7WU9+YgwoPiKw3/gEY1ICTKqCFevEG7QvaBcCOc2
 be0iQ9UQR9CvlGwDfr+B5O/B2lMMqORZkqIlZUOn1Gp/VXv4cjRmlFU8Wm5LGZFZD/Q790A
 BncMRVFzPF0wjvFA73AHKg8M+QrkLpMG6YLF/RWzoag6bwHxPB/BhTU6Yv4L8M0glUO3SkE
 Oo98jAgBw3/l7BsPM0sgw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:YoYRalT6D+c=:aogYtzu+iW6TCfePUKkjGU
 ngO6uCc8n4pNC4HG7hnSLoMQvFzEQ+oVews9axxZlHqLhT1Ian1Kf701ld7SseZr1HsyCpYAX
 CONxkJ5c5CTXMT3+sS10hwQhHwb4dxj5wUWcBkl/nz8MI+WdZQvqLTRPRYDfmWKYSabgUDGa5
 jEfLdJ0LLXTDILs/GjLjJ5nYuLQkhvw3mW9oGSEOaCV7aGVjUElIuSz2GGqYJy9C71YRRa8Ac
 XNMV2mBai/K80GJYYE+1PIivK7mMvAo2Xl6OTld9MaaKQ4ejLJY+uYuPZ9oe63DzqZbq4Djp1
 9Htc+l27XXQLIInldqbtd+/eCKeslcfWWvgXsVL0I3GUfb/0zXqn1JYA4cyGRrsTXCc3ACQaP
 Er144hR4O48vNAlimrIR0cDMaFe4NB16Ih9Go3Ua1POol1k+L2SET2uTa2jzIwftqnYezyxLi
 W/AV+mxUKCr7HUrrMQR+CYKQOaaqMBVAbLHxBX5BBgZVaa6GAYsPJHFYDwkpePwwsrRO5EEL7
 5to8oARggyemRHJeXwczE9ZwCJR3g9YQ8DQFeXspeIe8o9cDLD5NRS1+oJ9Udyhq5Y/6X/xeP
 NxYX6cEszVjFaOjy5VaTOvsDC+bk261C0yNqsJ7Txd/IW6Kgf7aKX+Wj8g/7idw4e464giZIR
 HIvTo/Fs9z7C6yz1QN55KeZeL42fUb3UqrRVaRB9eqcq8+zZigsHIuF+8TyneitMetBJBfUo3
 tV8VuzvrlfL/pnHO
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Monday 02 November 2015 13:56:31 Daniel Lezcano wrote:
>  static inline void rk_timer_disable(struct clock_event_device *ce)
>  {
>         writel_relaxed(TIMER_DISABLE, rk_base(ce) + TIMER_CONTROL_REG);
> -       dsb();
> +       dsb(sy);
>  }
>  
>  static inline void rk_timer_enable(struct clock_event_device *ce, u32 flags)
>  {
>         writel_relaxed(TIMER_ENABLE | TIMER_INT_UNMASK | flags,
>                        rk_base(ce) + TIMER_CONTROL_REG);
> -       dsb();
> +       dsb(sy);
>  }
>  
> 

This will fail the compile test, because dsb() is not available on non-ARM
architectures. Would it be enough to just use the normal writel() accessor
here?

	Arnd