From: "H. Peter Anvin" <hpa@zytor.com>
To: "Zhang, Jun" <jun.zhang@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "x86@kernel.org" <x86@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"Fleming, Matt" <matt.fleming@intel.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] To crash dump, we need keep other memory type except E820_RAM, because other type come from BIOS or firmware is used by other code(for example: PCI_MMCONFIG).
Date: Fri, 02 Nov 2012 09:37:46 -0700 [thread overview]
Message-ID: <5093F6DA.7040709@zytor.com> (raw)
In-Reply-To: <88DC34334CA3444C85D647DBFA962C270FD7F039@SHSMSX102.ccr.corp.intel.com>
On 11/01/2012 01:49 AM, Zhang, Jun wrote:
> Hello, Anvin
>
> Thank for your advice.
>
> Hello, All
>
> the next patch is made by 2), please review it. Thanks!
>
No, it is not.
You are still modifying the behavior of the kernel depending on
CONFIG_CRASH_DUMP.
CONFIG_CRASH_DUMP doesn't mean "we are doing a crash dump". It means
"it is possible to use this kernel to do a crash dump".
Either you are using standard kernel parameters in a standard way which
is what option 2 was supposed to be -- it should require no kernel
changes! -- or you have to put something in a code path specific to a
crash dump.
-hpa
next prev parent reply other threads:[~2012-11-02 16:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 1:26 Zhang, Jun
2012-10-31 2:46 ` H. Peter Anvin
2012-10-31 3:39 ` Zhang, Jun
2012-10-31 4:38 ` H. Peter Anvin
2012-10-31 5:22 ` Zhang, Jun
2012-10-31 5:38 ` H. Peter Anvin
2012-11-01 2:15 ` Zhang, Jun
2012-11-01 4:20 ` H. Peter Anvin
2012-11-01 8:49 ` Zhang, Jun
2012-11-02 15:08 ` Paul Gortmaker
2012-11-02 16:37 ` H. Peter Anvin [this message]
2012-11-05 1:37 ` [PATCH] crash dump: don't delete non-E820_RAM during init Zhang, Jun
2012-11-05 2:39 ` H. Peter Anvin
2012-11-05 2:57 ` Zhang, Jun
2012-11-05 2:59 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5093F6DA.7040709@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=jun.zhang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@redhat.com \
--cc=paul.gortmaker@windriver.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome