From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757778Ab3ANVYg (ORCPT ); Mon, 14 Jan 2013 16:24:36 -0500 Received: from mail.savoirfairelinux.com ([209.172.62.77]:44013 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757033Ab3ANVYf (ORCPT ); Mon, 14 Jan 2013 16:24:35 -0500 Date: Mon, 14 Jan 2013 16:24:22 -0500 (EST) From: Vivien Didelot To: Grant Likely Cc: spi-devel-general@lists.sourceforge.net, linux-kernel@vger.kernel.org, Mark Brown Message-ID: <509501101.524434.1358198662068.JavaMail.root@mail.savoirfairelinux.com> In-Reply-To: <20130114201128.ECDD13E249D@localhost> Subject: Re: [PATCH] spi: erase pointer to drvdata on removal MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [208.88.110.46] X-Mailer: Zimbra 7.1.4_GA_2555 (ZimbraWebClient - FF3.0 (Linux)/7.1.4_GA_2555) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, Grant, > On Mon, 14 Jan 2013 02:51:45 +0000, Mark Brown > wrote: > > On Thu, Nov 01, 2012 at 02:05:36PM -0400, Vivien Didelot wrote: > > > As for i2c-core, let the SPI core handle the removal of the > > > device's > > > drvdata, after a remove() or a probe() failure. > > > > Any driver that notices this change is buggy, the driver shouldn't > > use a drvdata value that it didn't set. I had thought this stuff > > had > > all been removed from I2C and either dropped or factored out into > > the > > driver core... > > Looks to me like __device_release_driver() in drivers/base/dd.c > already > does this. > > g. You are right, I figured this out after the resend of this patch, see my reply here: https://lkml.org/lkml/2012/12/4/224 -Vivien