From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80FD6C4363D for ; Tue, 22 Sep 2020 18:11:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D3992376F for ; Tue, 22 Sep 2020 18:11:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726710AbgIVSLK convert rfc822-to-8bit (ORCPT ); Tue, 22 Sep 2020 14:11:10 -0400 Received: from smtp.h3c.com ([60.191.123.56]:15152 "EHLO h3cspam01-ex.h3c.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726526AbgIVSLK (ORCPT ); Tue, 22 Sep 2020 14:11:10 -0400 Received: from h3cspam01-ex.h3c.com (localhost [127.0.0.2] (may be forged)) by h3cspam01-ex.h3c.com with ESMTP id 08MFVQZ3069235 for ; Tue, 22 Sep 2020 23:31:26 +0800 (GMT-8) (envelope-from tian.xianting@h3c.com) Received: from DAG2EX10-IDC.srv.huawei-3com.com ([10.8.0.73]) by h3cspam01-ex.h3c.com with ESMTPS id 08MFRMLE067100 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 22 Sep 2020 23:27:22 +0800 (GMT-8) (envelope-from tian.xianting@h3c.com) Received: from DAG2EX03-BASE.srv.huawei-3com.com (10.8.0.66) by DAG2EX10-IDC.srv.huawei-3com.com (10.8.0.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 22 Sep 2020 23:27:27 +0800 Received: from DAG2EX03-BASE.srv.huawei-3com.com ([fe80::5d18:e01c:bbbd:c074]) by DAG2EX03-BASE.srv.huawei-3com.com ([fe80::5d18:e01c:bbbd:c074%7]) with mapi id 15.01.1713.004; Tue, 22 Sep 2020 23:27:27 +0800 From: Tianxianting To: Christoph Hellwig , Keith Busch CC: "axboe@fb.com" , "sagi@grimberg.me" , "linux-nvme@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] [v2] nvme: replace meaningless judgement by checking whether req is null Thread-Topic: [PATCH] [v2] nvme: replace meaningless judgement by checking whether req is null Thread-Index: AQHWkKof6KH2tOMk4EuCjM46q9dNfal0OdSAgAAAdACAAI18gA== Date: Tue, 22 Sep 2020 15:27:27 +0000 Message-ID: <5099986543624f9fbbeb26c2173934ba@h3c.com> References: <20200922062517.30031-1-tian.xianting@h3c.com> <20200922145705.GA4035426@dhcp-10-100-145-180.wdl.wdc.com> <20200922145842.GB28420@lst.de> In-Reply-To: <20200922145842.GB28420@lst.de> Accept-Language: en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.99.141.128] x-sender-location: DAG2 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-DNSRBL: X-MAIL: h3cspam01-ex.h3c.com 08MFRMLE067100 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thank you Keith, Christoph, So I don't need to send v3 patch? -----Original Message----- From: Christoph Hellwig [mailto:hch@lst.de] Sent: Tuesday, September 22, 2020 10:59 PM To: Keith Busch Cc: tianxianting (RD) ; axboe@fb.com; hch@lst.de; sagi@grimberg.me; linux-nvme@lists.infradead.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH] [v2] nvme: replace meaningless judgement by checking whether req is null On Tue, Sep 22, 2020 at 07:57:05AM -0700, Keith Busch wrote: > The commit subject is a too long. We should really try to keep these > to > 50 characters or less. > > nvme-pci: fix NULL req in completion handler > > Otherwise, looks fine. > > Reviewed-by: Keith Busch Yes. I was about to apply it with a similar edit, but I'll take yours happily.