From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C27AE3B2FEB for ; Thu, 28 May 2026 09:56:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779962223; cv=none; b=YugCqafAV/hNTDaF70LvyUyXMEojyyhThSbGlRnBALjqhixh7J7GQ7WEokxGlkc6pScNFrINwobzSGkLL6EPHcM7dYyswrH9D3x8soNp1XZPZQzPCGMLFr//23Yiscf/JJ6S8RMwZ8dw2opP7cp4fozhA1t3bxgZGMqkxfKO3Rg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779962223; c=relaxed/simple; bh=6iyY+VWpWK7RjeJO5ZIKek+NCJJXEjC6sQPd343u7OE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KrszKKlw2N0lS/muLJJExTY6ML4I59e7f9aORMMB/8gpWRuXuxFA3K8eSUzA7i1B74X4DQ7qi6ZZshai+ajRYd4ZJdXRTFxVtn/rWiGqrDlIxSVWwoLCTzBUILbgD18QmUQqza+M9VoSVo84LtGFCuWqHacQSLETFEqZAW/aCII= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=QFUzIx8p; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="QFUzIx8p" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4903f7a90d1so55461105e9.2 for ; Thu, 28 May 2026 02:56:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1779962217; x=1780567017; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UksBgfe71dRRTKPOD06jM/48YsZk+2Jj0c99vtBZapI=; b=QFUzIx8p5RfBo2tI0DU9sTeaPZeHFDKuiHGxOFbnqn6zZo3QWcwK7KHTN+a5iSYN1y cvi09NlxgqmxhPNqRmC4pMUFh/dcnW5hdtlL6aCOKbY0yn1AV9CO8DbLmAGzJmNSQBGN +CG+s5Kgw24RHfmckB30i7eodyM8I1UCkaEALgpn27/FsMuX3gcZ3JucjExPpkT71wVB 0XEQew+CRNw+pSHLNHwzgM5V7/K4A8ZPujoPpz+0GPut0Ek2EpmJUiSzVg1lJlf3pdXj MFyL/s+A7WhGP91AzQd4jqOpybHepZL6z7IPlVebi1D5W90fR3DM8qit2+myxSVZXhxT bOqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779962217; x=1780567017; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UksBgfe71dRRTKPOD06jM/48YsZk+2Jj0c99vtBZapI=; b=DAwgGUVwWC8LZ5jLOOZyA28qNOlEH2tnReswCK19Rbi6XL8YOJC+16b+Sf8b6zztiW fwjTpwe07s5KMESkd7xq5JjFC7dPSWPZRaSOSkvHIUnXIqC1biUeye7FkWu6roR1+bFZ 8h/7yFL69vRouVVo97lOuLXRb5848WW8t4telk4qHEBogI9oXpZyXQogyLbb/JwnGSbu igDFLPeubWGjdpy9FGIheyfaGMzRmEonwZbHE+60hOg8G/+ytt5pj7Nw8IMkLHiAevoz I1S4QcyIvOPZXin6ih3W2sWIqkGVA6f8PS3I4fZ3Oi3Rddm9pV9J18gsjKSkC88LutbF lVVQ== X-Forwarded-Encrypted: i=1; AFNElJ/Y6FwLhXQuEqXSd7Ao80BhLyDEfpua5fB65ARdcNUY6Dx76/Bqf8iW3UXhgjPS2K/fQo9dxYCJazKeigw=@vger.kernel.org X-Gm-Message-State: AOJu0YyT17eBc+LKmV4QndMKsD1tdjXhUR8e8z4C0Ir/ujALVku4L9Du o4sDgEIezq+vpBaWFwecBf+K8oB9mQZYBBiFX6HMLSnjXZ6rPRotXOu5g5qLpadI9c8zhfzGzsp di0Io X-Gm-Gg: Acq92OFlr0JXAhpsH0zybUKpPCGvi/Z4cdIyJWoiR/B+FjosgVnrwTLPuWoIxG/Ujak hrPooBtdvwvwJCpVTqlIIbtiVRgECxgdmDs6IFkfcTlTm9905LWOMTUCjG8SIWEVOwlxT9rbZbE hqFWqxIifcAMu204fDYMY6tVK1zp8H1x0sAQHVpSWgqydr6mFncSEvx/pMcoOrDbLw14En+6+A5 aevhvP/cq/MyhVJYJLiAWEGPeC6GKJXNqwkfPeyJo2Oy+7s4ix7fAm2GKdBdKvfxy39WbgbUouq QnJ/w9a+ZoERWPem3Di0S+OOkb6ycd7vl+tuQlzsFUXnMlcrTnAWllwsuX+jPDHGhRhmEWuV4Fa MI5o0wgc8c8Cd4jLFJKzkTvSQfhZdlu+4kGlfUBc1U2NELV2HQ/XTUr2VTnw2NkZBWnzBybS5Qp P3ljS4HS+aJlvzHo/ZSjP+REHwl3553axi25JdMj+BAxgZpz2LMeIl4SN7eoJn9rwlP1mP9v808 rVU1iA38MkoOA== X-Received: by 2002:a05:600c:1550:b0:490:48a0:b87a with SMTP id 5b1f17b1804b1-49048a0b90dmr417866725e9.9.1779962217425; Thu, 28 May 2026 02:56:57 -0700 (PDT) Received: from ?IPV6:2001:a61:13de:8701:3ac2:500e:384:fbe1? ([2001:a61:13de:8701:3ac2:500e:384:fbe1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4908ecb5238sm13644335e9.24.2026.05.28.02.56.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 May 2026 02:56:56 -0700 (PDT) Message-ID: <5099d6cc-c8bc-4fdc-97cf-31e96a57e0c1@suse.com> Date: Thu, 28 May 2026 11:56:55 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] usb: misc: yurex: fix ordering of usb_deregister_dev() and usb_set_intfdata() To: Junzhe Li , gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260528082751.204898-1-ginger.jzllee@gmail.com> Content-Language: en-US From: Oliver Neukum In-Reply-To: <20260528082751.204898-1-ginger.jzllee@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 28.05.26 10:27, Junzhe Li wrote: > In yurex_disconnect(), usb_set_intfdata(interface, NULL) was called > before usb_deregister_dev(interface, &yurex_class). > This opens a race window with usb_open() in the USB core: > > T0 (yurex_disconnect) T1 (usb_open) > -------------------------- ------------------------- > usb_set_intfdata(iface, NULL) [t0] > fops = usb_minors[minor] [t1] > /* fops still valid here */ > usb_deregister_dev() > usb_minors[minor] = NULL [t2] > file->f_op->open(inode, file) > yurex_open() > dev = usb_get_intfdata() [t3] > /* dev is NULL! */ Yes, but yurex_open() checks for dev == NULL Could you please elaborate? Regards Oliver