From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Erikas Bitovtas <xerikasxx@gmail.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] arm64: dts: qcom: msm8939-asus-z00t: add battery
Date: Fri, 5 Dec 2025 12:51:46 +0100 [thread overview]
Message-ID: <509d5d7d-b7a3-4dc9-b3e6-c3e52abe040c@oss.qualcomm.com> (raw)
In-Reply-To: <20251121-battery-hall-v2-1-d29e0828f214@gmail.com>
On 11/21/25 12:10 AM, Erikas Bitovtas wrote:
> This device tracks remaining battery capacity percentage using voltage
> mode BMS. This commit enables the pm8916_bms node and adds a battery
> node to track its capacity. Battery properties were taken from the
> information printed on the battery itself and downstream device tree
> for a battery named "nvt+atl_3000mah" [1]
>
> [1] https://github.com/Asus-MSM8916/android_kernel_asus_msm8916/blob/10.x/arch/arm/boot/dts/qcom/ASUS_ZE550KL_1936167_3000mAh_3p4COV_VBMS_Final.dtsi
>
> Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
> ---
> arch/arm64/boot/dts/qcom/msm8939-asus-z00t.dts | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8939-asus-z00t.dts b/arch/arm64/boot/dts/qcom/msm8939-asus-z00t.dts
> index ebb548e62e02..b58f0a04abfd 100644
> --- a/arch/arm64/boot/dts/qcom/msm8939-asus-z00t.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8939-asus-z00t.dts
> @@ -20,6 +20,25 @@ aliases {
> serial0 = &blsp_uart2;
> };
>
> + battery: battery {
> + compatible = "simple-battery";
> + device-chemistry = "lithium-ion-polymer";
> + voltage-min-design-microvolt = <3400000>;
> + voltage-max-design-microvolt = <4400000>;
> + energy-full-design-microwatt-hours = <11500000>;
> + charge-full-design-microamp-hours = <3000000>;
> +
> + ocv-capacity-celsius = <25>;
> + ocv-capacity-table-0 = <4372000 100>, <4306000 95>, <4247000 90>,
> + <4190000 85>, <4134000 80>, <4081000 75>, <4030000 70>,
> + <3984000 65>, <3930000 60>, <3884000 55>, <3850000 50>,
> + <3826000 45>, <3804000 40>, <3786000 35>, <3770000 30>,
> + <3753000 25>, <3734000 20>, <3712000 16>, <3693000 13>,
> + <3686000 11>, <3684000 10>, <3682000 9>, <3680000 8>,
> + <3676000 7>, <3668000 6>, <3643000 5>, <3600000 4>,
> + <3542000 3>, <3462000 2>, <3340000 1>, <3000000 0>;
I was surprised to learn the binding allows you to specify the OCV table
for multiple temperature points (your downstream provides -20/0/25/40/60)
May I ask you to fill in that data?
Konrad
next prev parent reply other threads:[~2025-12-05 11:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-20 23:10 [PATCH v2 0/2] Asus ZenFone 2 Laser/Selfie includes a battery measured by voltage mode BMS and a simple GPIO hall effect sensor. The following commits include support for these components Erikas Bitovtas
2025-11-20 23:10 ` [PATCH v2 1/2] arm64: dts: qcom: msm8939-asus-z00t: add battery Erikas Bitovtas
2025-12-05 11:51 ` Konrad Dybcio [this message]
2025-12-05 16:30 ` Erikas Bitovtas
2025-11-20 23:10 ` [PATCH v2 2/2] arm64: dts: qcom: msm8939-asus-z00t: add hall sensor Erikas Bitovtas
2025-11-21 14:04 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509d5d7d-b7a3-4dc9-b3e6-c3e52abe040c@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=xerikasxx@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®