Re: [PATCH v2] add xen-tpmfront.ko: Xen Virtual TPM frontend driver

[Matthew Fioravante <matthew.fioravante@jhuapl.edu>]

[-- Attachment #1: Type: text/plain, Size: 1099 bytes --]

On 11/12/2012 11:30 AM, Konrad Rzeszutek Wilk wrote:
> On Mon, Nov 12, 2012 at 09:29:58AM -0500, Matthew Fioravante wrote:
>> This patch ports the xen vtpm frontend driver for linux
>> from the linux-2.6.18-xen.hg tree to linux-stable. This
>> driver is designed be used with the mini-os tpmback driver
>> in Xen as part of the new mini-os virtual tpm subsystem.
>> See docs/misc/vtpm.txt in Xen and the xen-devel mailing list
>> for details.
> I didn't look in details but off the bat - you are missing
> the Documentation/../sysfs file.
It looks like Kent submitted a patch that documents sysfs generically
for all of the TPM drivers.
>
> I still think you should include the full vtpm.txt in this
> patch description and refer at the end to the docs/misc/vtpm.txt
> in Xen as the source for the up-to-date version.
The current docs/misc/vtpm.txt in Xen is still the old version. I've 
just written a new one and am reviewing it. It will come in the next 
resubmission of my vtpm patches to xen. I'll include the text here for 
the next resubmission of this patch as well.



[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 1459 bytes --]