Re: [RFC PATCH v2 00/15] NFSd state containerization

[Stanislav Kinsbursky <skinsbursky@parallels.com>]

15.11.2012 02:00, J. Bruce Fields пишет:
> On Wed, Nov 14, 2012 at 06:20:59PM +0300, Stanislav Kinsbursky wrote:
>> This patch set is my first attempt to containerize NFSv4 state - i.e. make it
>> works in networks namespace context.
>> I admit, that some of this new code could be partially rewritten during future
>> NFSd containerization.
>> But the overall idea look more or less correct to me.
>> So, the main things here are:
>> 1) making nfs4_client network namespace aware.
>> 2) Allocating all hashes (except file_hashtbl and reclaim_str_hashtbl) per
>> network namespace context on NFSd start (not init) and destroying on NFSd
>> state shutdown.
>> 3) Allocating of reclaim_str_hashtbl on legacy tracker start and destroying on
>> legacy tracker stop.
>> 4) Moving of client_lru and close_lru lists to per-net data.
>> 5) Making lundromat network namespace aware.
>
> These look OK and pass my tests.  Jeff, do the revised recovery bits
> look OK?
>
> Have you done any testing?

I've done basic testing. I.e. NFS server start/stop in loop, export, share mount 
on another node and some activity, etc.
NFS server is not ready yet to work on container, so no such testing has been done.

>
> It'd be interesting, for example, to know if there are any pynfs that
> fail against the server in a non-init network namespace, but pass
> normally.
>
> --b.
>


-- 
Best regards,
Stanislav Kinsbursky