From: Eli Billauer <eli.billauer@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, arnd@arndb.de
Subject: Re: [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)
Date: Sun, 02 Dec 2012 19:26:27 +0200 [thread overview]
Message-ID: <50BB8F43.4010208@gmail.com> (raw)
In-Reply-To: <20121130163254.GB4478@kroah.com>
On 11/30/2012 06:32 PM, Greg KH wrote:
>>>> > >>+static struct class *xillybus_class;
>>>>
>>> > >Why not just use the misc interface instead of your own class?
>>>
>> > When Xillybus is used, the whole system's mission is usually around
>> > it (e.g. it's a computer doing data acquisition through the Xillybus
>> > pipes). So giving it a high profile makes sense, I believe. Besides,
>> > a dozen of device files are not rare.
>>
> It is no problem to create dozens of misc devices. It makes your driver
> smaller, contain less code that I have to audit and you have to ensure
> you got right, and it removes another user of 'struct class' which we
> are trying to get rid of anyway. So please, move to use a misc device.
>
>
It has just occurred to me that DYNAMIC_MINORS is 64
(drivers/char/misc.c), so I guess that limits the number of misc devices
that can be generated, at least with dynamically allocated minors. I
previously mentioned "a dozen" as the number of devices, but I've
already run tests with 100+ devices, and I can also think of a sane
application for that.
So if I understood the situation correctly, it looks like using misc
devices will create a limitation which will be reached sooner or later.
Any suggestion what to do?
Thanks in advance,
Eli
next prev parent reply other threads:[~2012-12-02 17:46 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-28 15:41 [PATCH 1/2] pci_ids: Added FPGA-related entries Eli Billauer
2012-11-28 15:41 ` [PATCH 2/2] New driver: Xillybus generic interface for FPGA (programmable logic) Eli Billauer
2012-11-28 16:57 ` Greg KH
2012-11-30 14:50 ` Eli Billauer
2012-11-30 16:32 ` Greg KH
2012-11-30 16:58 ` Eli Billauer
2012-11-30 17:32 ` Arnd Bergmann
2012-12-02 17:26 ` Eli Billauer [this message]
2012-12-04 3:41 ` Greg KH
2012-12-04 10:13 ` Eli Billauer
2012-12-04 20:43 ` Arnd Bergmann
2012-12-04 21:42 ` Eli Billauer
2012-12-04 23:05 ` Arnd Bergmann
2012-12-05 0:03 ` Eli Billauer
2012-12-05 15:48 ` Greg KH
2012-11-30 17:28 ` Arnd Bergmann
2012-11-30 17:36 ` Greg KH
2012-12-01 3:19 ` Philip Balister
2012-12-01 16:56 ` Greg KH
2012-12-01 16:58 ` Greg KH
2012-12-01 19:30 ` Philip Balister
2012-12-01 20:33 ` Josh Cartwright
2012-12-01 20:48 ` Arnd Bergmann
2012-12-02 12:38 ` Eli Billauer
2012-12-03 20:24 ` John Linn
2012-12-04 19:49 ` Philip Balister
2012-12-04 20:54 ` Arnd Bergmann
2012-12-05 12:34 ` Pavel Machek
2012-11-28 16:50 ` [PATCH 1/2] pci_ids: Added FPGA-related entries Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50BB8F43.4010208@gmail.com \
--to=eli.billauer@gmail.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome