mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexander Holler <holler@ahsoftware.de>
To: "Lothar Waßmann" <LW@KARO-electronics.de>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
	rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [BUGFIX PATCH] rtc: eliminate extra call of ida_simple_remove()
Date: Thu, 06 Dec 2012 16:17:24 +0100	[thread overview]
Message-ID: <50C0B704.5050808@ahsoftware.de> (raw)
In-Reply-To: <1354721131-31177-1-git-send-email-LW@KARO-electronics.de>

Am 05.12.2012 16:25, schrieb Lothar Waßmann:
> Unbinding an RTC chip driver from its device leads to the error
> message:
> |ida_remove called for id=0 which is not allocated.
>
> This is caused by a redundant call to ida_simple_remove() in
> rtc_device_unregister().
> Eliminate the call in rtc_device_unregister() and only call the
> function in rtc_device_release().
>
> Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>

I've just discovered the same problem. Although I've removed the call to
ida_simple_remove() in rtc_device_release() (for symmetry of 
register/unregister) I can offer a

Signed-off-by: Alexander Holler

A

Cc: <stable@vger.kernel.org>

might make sense, but it should just remove a warning, so I don't know 
if that qualifies for the stable series.

Regards,

Alexander



      reply	other threads:[~2012-12-06 15:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-05 15:25 Lothar Waßmann
2012-12-06 15:17 ` Alexander Holler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50C0B704.5050808@ahsoftware.de \
    --to=holler@ahsoftware.de \
    --cc=LW@KARO-electronics.de \
    --cc=a.zummo@towertech.it \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome