From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754462Ab2LFVJp (ORCPT ); Thu, 6 Dec 2012 16:09:45 -0500 Received: from wolverine01.qualcomm.com ([199.106.114.254]:22827 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750857Ab2LFVJo (ORCPT ); Thu, 6 Dec 2012 16:09:44 -0500 X-IronPort-AV: E=McAfee;i="5400,1158,6918"; a="12203148" Message-ID: <50C10997.8090801@codeaurora.org> Date: Thu, 06 Dec 2012 13:09:43 -0800 From: Laura Abbott User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/20121026 Thunderbird/16.0.2 MIME-Version: 1.0 To: Laura Abbott CC: Mel Gorman , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v2] mm: Use aligned zone start for pfn_to_bitidx calculation References: <1354824324-21993-1-git-send-email-lauraa@codeaurora.org> In-Reply-To: <1354824324-21993-1-git-send-email-lauraa@codeaurora.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/6/2012 12:05 PM, Laura Abbott wrote: > The current calculation in pfn_to_bitidx assumes that > (pfn - zone->zone_start_pfn) >> pageblock_order will return the > same bit for all pfn in a pageblock. If zone_start_pfn is not > aligned to pageblock_nr_pages, this may not always be correct. > > Consider the following with pageblock order = 10, zone start 2MB: > > pfn | pfn - zone start | (pfn - zone start) >> page block order > ---------------------------------------------------------------- > 0x26000 | 0x25e00 | 0x97 > 0x26100 | 0x25f00 | 0x97 > 0x26200 | 0x26000 | 0x98 > 0x26300 | 0x26100 | 0x98 > > This means that calling {get,set}_pageblock_migratetype on a single > page will not set the migratetype for the full block. Fix this by > rounding down zone_start_pfn when doing the bitidx calculation. > > Signed-off-by: Laura Abbott > --- > mm/page_alloc.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 92dd060..2e06abd 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -5422,7 +5422,7 @@ static inline int pfn_to_bitidx(struct zone *zone, unsigned long pfn) > pfn &= (PAGES_PER_SECTION-1); > return (pfn >> pageblock_order) * NR_PAGEBLOCK_BITS; > #else > - pfn = pfn - zone->zone_start_pfn; > + pfn = pfn - round_down(zone->start_pfn, pageblock_nr_pages); > return (pfn >> pageblock_order) * NR_PAGEBLOCK_BITS; > #endif /* CONFIG_SPARSEMEM */ > } > Sorry for the spam, please ignore this one. This has a typo. Third times the charm. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation