From: "Ying-Chun Liu (PaulLiu)" <paulliu@debian.org>
To: Axel Lin <axel.lin@ingics.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Nancy Chen <Nancy.Chen@freescale.com>, Liam Girdwood <lrg@ti.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFT 1/2] regulator: anatop: Use linear_min_sel with linear mapping
Date: Sun, 09 Dec 2012 13:37:19 +0800 [thread overview]
Message-ID: <50C4238F.4050900@debian.org> (raw)
In-Reply-To: <1355011545.3283.1.camel@phoenix>
於 2012年12月09日 08:05, Axel Lin 提到:
> By setting linear_min_sel to anatop_reg->min_bit_val, we can avoid
> adjust the anatop_reg->min_bit_val offset in [set|get]_voltage_sel.
>
> With this chance we can refactor this driver to use
> regulator_[get|set]_voltage_sel_regmap.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Reviewed-by: Ying-Chun Liu <paulliu@debian.org>
Looks good to me and I just test the path and it works.
--
PaulLiu (劉穎駿)
E-mail: Ying-Chun Liu (PaulLiu) <paulliu@debian.org>
next prev parent reply other threads:[~2012-12-09 5:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-09 0:05 Axel Lin
2012-12-09 0:07 ` [PATCH RFT 2/2] regulator: anatop: Use regulator_[get|set]_voltage_sel_regmap Axel Lin
2012-12-09 5:38 ` Ying-Chun Liu (PaulLiu)
2012-12-09 5:37 ` Ying-Chun Liu (PaulLiu) [this message]
2012-12-10 3:12 ` [PATCH RFT 1/2] regulator: anatop: Use linear_min_sel with linear mapping Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C4238F.4050900@debian.org \
--to=paulliu@debian.org \
--cc=Nancy.Chen@freescale.com \
--cc=axel.lin@ingics.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome